Conversation
janbrasna
left a comment
There was a problem hiding this comment.
The CI runs that twice:
- /actions/runs/22524118040/job/65253378571#step:5:33
- /actions/runs/22524118040/job/65253378571#step:6:10
and is apparently happy.
| /* eslint-env node, commonjs, es2017 */ | ||
|
|
||
| const CopyPlugin = require('copy-webpack-plugin'); | ||
| const path = require('path'); |
There was a problem hiding this comment.
Worth noting the new globals are defined slightly differently:
Lines 124 to 132 in d20837b
There was a problem hiding this comment.
(But then again, whatever format the webpack configs become over time, the change from es-2017 to es-latest should have no meaningful impact.) — Expecting the newer flat config values having taken precedence, they've been used like this over a year anyways FWIW.
| */ | ||
|
|
||
| /* eslint-env node, commonjs, es2017 */ | ||
|
|
There was a problem hiding this comment.
Yeah not sure why GH doesn't see that as merge conflict by now, potentially by being the exact same change it's still happy to merge w/o conflict just resulting in an empty commit by now? Dunno. Removed in 9e37287 in a bigger update at this point. 🚀
Description
These are defined in the new config since #935 and should no longer use the old format.
I have documented this change in the design system.I have recorded this change inCHANGELOG.md.Issue
#1121
Testing
CI pass on v9 should be enough to verify v10 compatibility of these removals.