Skip to content

Standardize component focus states on :focus-visible #1141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
stephaniehobson wants to merge 1 commit into from
Open

Standardize component focus states on :focus-visible #1141

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,9 @@ Introducing theme variables! CSS variables beginning with `--theme-` will adjust
* Added status color variables (`--theme-color-success-*`, `--theme-color-error-*`, `--theme-color-warning-*`, `--theme-color-info-*`)
* Removed Sass color variables from `_themes-sass.scss` (use CSS variables instead)

### Accessibility

* (breaking) Standardized interactive component states on `:focus-visible` instead of `:focus`.
## Component changes

### Feature Card
Expand Down
2 changes: 1 addition & 1 deletion assets/sass/protocol/components/_breadcrumb.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@

&:hover,
&:active,
&:focus {
&:focus-visible {
text-decoration: none;
}
}
Expand Down
4 changes: 2 additions & 2 deletions assets/sass/protocol/components/_button.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
box-shadow: none;
}

&:focus {
&:focus-visible {
border-color: var(--theme-button-border-color-focus);
box-shadow: var(--theme-field-focus-ring);
outline-offset: 1px;
Expand Down Expand Up @@ -213,7 +213,7 @@

&:hover,
&:active,
&:focus {
&:focus-visible {
text-decoration: underline;
}
}
Expand Down
4 changes: 2 additions & 2 deletions assets/sass/protocol/components/_card.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@

&:hover,
&:active,
&:focus {
&:focus-visible {
transition: box-shadow 0.1s ease-in-out;
box-shadow: 0 0 0 4px $color-marketing-gray-20;

Expand Down Expand Up @@ -143,7 +143,7 @@

&:hover,
&:active,
&:focus {
&:focus-visible {
box-shadow: 0 0 0 4px $color-marketing-gray-80;
}

Expand Down
10 changes: 5 additions & 5 deletions assets/sass/protocol/components/_footer.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
text-decoration: underline;

&:hover,
&:focus,
&:focus-visible,
&:active {
text-decoration: none;
}
Expand Down Expand Up @@ -93,7 +93,7 @@
text-decoration: none;

&:hover,
&:focus,
&:focus-visible,
&:active {
text-decoration: underline;
}
Expand Down Expand Up @@ -171,7 +171,7 @@
padding: 0;
border-bottom: 0;

button:focus {
button:focus-visible {
outline: 1px dotted #fff;
}

Expand Down Expand Up @@ -240,7 +240,7 @@
color: tokens.$color-light-gray-50;

&:hover,
&:focus,
&:focus-visible,
&:active {
text-decoration: none;
}
Expand Down Expand Up @@ -291,7 +291,7 @@
}

&:hover,
&:focus {
&:focus-visible {
border-bottom-color: var(--theme-body-text-color-inverse);
}
}
Expand Down
4 changes: 2 additions & 2 deletions assets/sass/protocol/components/_menu-item.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ $icon-size: 24px;

&:hover,
&:active,
&:focus {
&:focus-visible {
.mzp-c-menu-item-title {
transition: border-bottom-color 100ms ease-in-out;
border-bottom: 2px solid var(--theme-body-text-color);
Expand Down Expand Up @@ -82,7 +82,7 @@ $icon-size: 24px;

&:hover,
&:active,
&:focus {
&:focus-visible {
color: var(--theme-body-text-color);
text-decoration: underline;
}
Expand Down
4 changes: 2 additions & 2 deletions assets/sass/protocol/components/_menu-list.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@
}

&:hover,
&:focus {
&:focus-visible {
background: $color-marketing-gray-20;
color: var(--theme-link-color-hover);

Expand Down Expand Up @@ -99,7 +99,7 @@
}

&:hover,
&:focus {
&:focus-visible {
color: var(--theme-link-color-hover);
text-decoration: none;

Expand Down
6 changes: 3 additions & 3 deletions assets/sass/protocol/components/_menu.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@

&:hover,
&:active,
&:focus {
&:focus-visible {
color: inherit;
text-decoration: underline;
}
Expand Down Expand Up @@ -137,7 +137,7 @@
}

&.mzp-has-drop-down:hover,
&.mzp-has-drop-down:focus {
&.mzp-has-drop-down:focus-visible {
.mzp-c-menu-title {
@include highlighted;
z-index: 1001;
Expand Down Expand Up @@ -225,7 +225,7 @@
width: 16px;

&:hover,
&:focus {
&:focus-visible {
transform: scale(1.2);
}

Expand Down
4 changes: 2 additions & 2 deletions assets/sass/protocol/components/_modal.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,12 +88,12 @@ html.mzp-is-noscroll {
cursor: pointer;

&:hover,
&:focus {
&:focus-visible {
transition: transform 0.1s ease-in-out;
transform: scale(1.1);
}

&:focus {
&:focus-visible {
outline: 1px dotted var(--theme-body-text-color-inverse);
}
}
Expand Down
2 changes: 1 addition & 1 deletion assets/sass/protocol/components/_navigation.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,7 +200,7 @@

&:hover,
&:active,
&:focus,
&:focus-visible,
&.mzp-is-active {
background-color: $color-marketing-gray-20;
}
Expand Down
14 changes: 7 additions & 7 deletions assets/sass/protocol/components/_notification-bar.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@

&:hover,
&:active,
&:focus {
&:focus-visible {
color: inherit;
text-decoration: none;
}
Expand Down Expand Up @@ -76,7 +76,7 @@
cursor: pointer;
}

&:focus {
&:focus-visible {
border: 1px solid;
}

Expand All @@ -91,7 +91,7 @@
));

&:hover,
&:focus {
&:focus-visible {
background-color: $color-marketing-gray-50;
border: 0;
}
Expand All @@ -106,7 +106,7 @@
background-color: var(--theme-color-success-hover);

&:hover,
&:focus {
&:focus-visible {
background-color: var(--theme-color-success-active);
}
}
Expand All @@ -121,7 +121,7 @@
background-color: var(--theme-color-error-hover);

&:hover,
&:focus {
&:focus-visible {
background-color: var(--theme-color-error-active);
}
}
Expand All @@ -136,7 +136,7 @@
background-color: var(--theme-color-warning-hover);

&:hover,
&:focus {
&:focus-visible {
background-color: var(--theme-color-warning-active);
}
}
Expand All @@ -155,7 +155,7 @@
background-color: var(--theme-color-info-hover);

&:hover,
&:focus {
&:focus-visible {
background-color: var(--theme-color-info-active);
}
}
Expand Down
2 changes: 1 addition & 1 deletion assets/sass/protocol/components/_sidebar-menu.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@
transition: background-color 100ms ease-in;

&:hover,
&:focus,
&:focus-visible,
&:active {
background-color: rgb(0, 0, 0, 0.05);
text-decoration: underline;
Expand Down
2 changes: 1 addition & 1 deletion assets/sass/protocol/components/_sticky-promo.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ $logos: (
));

&:hover,
&:focus {
&:focus-visible {
cursor: pointer;
}

Expand Down
Loading