Repository navigation
Add splice #39
Description
ThinVec currently lacks the splice method. In rust-lang/rust#104754 I converted a bunch of Vec instances in rustc to ThinVec for some performance wins. I had to change one use of splice like this:
- alternatives.splice(idx..=idx, inner);
+
+ // Equivalent to `alternatives.splice(idx..=idx, inner);`.
+ alternatives.remove(idx);
+ for p in inner.into_iter().rev() {
+ alternatives.insert(idx, p);
+ }
which could cause quadratic behaviour.
Activity
nnethercote commentedon Dec 1, 2022
There is even a
TODO: implement splice?comment in the code.Gankra commentedon Dec 5, 2022
#41
marcospb19 commentedon Jun 28, 2023
Hey 👋, should this be closed due to #41?