sub/sd_sbr: implement get_{text,lines}#17820
Draft
afishhh wants to merge 2 commits intompv-player:masterfrom
Draft
sub/sd_sbr: implement get_{text,lines}#17820afishhh wants to merge 2 commits intompv-player:masterfrom
get_{text,lines}#17820afishhh wants to merge 2 commits intompv-player:masterfrom
Conversation
Contributor
Author
|
Going to release subrandr v1.3 with the required API soon.
This might actually end up being a temporary solution since I intend to introduce an API specifically for "rendering" to text at which point |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requires afishhh/subrandr#169, submitting this earlier in case there are any concerns about the API exposed by subrandr here.
The reason
get_texthas to be stateful can be seen in some (yes, this only happens in some of them) hololive subs where they have translation + original karaoke on screen:Naturally this still swaps the lines after seeking into the middle of such a segment or playing the video backwards but at least they're stable :)