Skip to content

options: make player-operation-mode readable as a property #17866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
na-na-hi wants to merge 2 commits into
base: master
Choose a base branch
from
+12 −4
Open

options: make player-operation-mode readable as a property #17866

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8bcc841
options: make player-operation-mode readable as a property
na-na-hi May 2, 2026
f90bfb0
DOCS/man/mpv: add usage hint alternative for pseudo-gui profile
na-na-hi May 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions DOCS/man/mpv.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1536,10 +1536,15 @@ works like in older mpv releases:
.. warning::

Currently, you can extend the ``pseudo-gui`` profile in the config file the
normal way. This is deprecated. In future mpv releases, the behavior might
change, and not apply your additional settings, and/or use a different
profile name.
normal way. This is deprecated and will be removed in future mpv releases.

As an alternative, a conditional autoprofile can be used instead:

::

[gui]
profile-cond=p["player-operation-mode"]=="pseudo-gui"
idle=once

.. include:: options.rst

Expand Down
3 changes: 3 additions & 0 deletions DOCS/man/options.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1090,6 +1090,9 @@ Program Behavior
only by mpv internally, or mpv-provided scripts, config files, or .desktop
files. See `PSEUDO GUI MODE`_ for details.

This option should be set at startup. Changing this option at runtime has no
effect.

Watch Later
-----------

Expand Down
2 changes: 1 addition & 1 deletion options/options.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -514,7 +514,7 @@ static const m_option_t mp_opts[] = {

{"player-operation-mode", OPT_CHOICE(operation_mode,
{"cplayer", 0}, {"pseudo-gui", 1}),
.flags = M_OPT_PRE_PARSE | M_OPT_NOPROP},
Copy link
Copy Markdown
Member

@kasper93 kasper93 May 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't this allow to change this option in runtime, which would be unexpected.

Copy link
Copy Markdown
Contributor Author

@na-na-hi na-na-hi May 3, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No existing clients can change it in runtime, and currently changing it at runtime has no effect. I added a note to mention it explicitly in the documentation.

I can also keep it in place and add current-player-operation-mode property instead but I think player-operation-mode is something that client should not change at runtime.

.flags = M_OPT_PRE_PARSE},

{"shuffle", OPT_BOOL(shuffle), .flags = M_OPT_PRE_PARSE},

Expand Down
Loading