Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a peer closes an SFTP channel, the local side emits
closewithout sending the reciprocalCHANNEL_CLOSE. The peer therefore retains a half-closed channel while the SSH connection stays open (#1522).I route SFTP channels through the existing
destroy()method in the shared close handler, preserving its state and connection-death guards. Regression tests cover both initiators, duplicate close packets, a subsequent command on the same connection, and already-closing/closed/dead controls.Validation: the complete suite (15 test scripts) and lint pass with Node 24.22.1/OpenSSH 9.2 in an isolated Linux arm64 container. The new regressions and lint also pass on macOS/Node 24.19. The full macOS suite retains an existing failure because OpenSSH 10.5 rejects the harness's
ssh-dssoptions; the same failure occurs on the original base. The optional crypto addon was not built.Fixes #1522