Repository navigation
fix: reject streams ending with incomplete records - #300
Open
HocVoNgThai wants to merge 1 commit into
Open
HocVoNgThai wants to merge 1 commit into
HocVoNgThai wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check for remaining array items, a pending value header or an unfinished container when an async decoding stream ends. Throw
RangeErrorinstead of reporting successful completion with missing records.For example, a stream containing
[{ id: 1 }, { id: 2 }]with its last byte missing currently finishes and returns only{ id: 1 }. With this change, it still yields the complete first item, then rejects when it detects that the second item is incomplete. Complete streams retain their current behavior.Adds regressions for array streams missing a whole item or part of its value, plus multi-record streams ending inside a string or nested object.
Closes #299