Allow default handler to take a position parameter#718
Open
PeterC-DLS wants to merge 2 commits into
Open
Conversation
This enables padding to be computed when packing a custom type and enables zero-copy unpacking by aligning primitives correctly
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This enables padding to be computed when packing a custom type and enables zero-copy unpacking by aligning primitives correctly. The code in
test_defaultdemonstrates correct padding forarrays.This is motivated by passing NumPy's
ndarrays with their raw data inbinformat to a web frontend whereTypedArrays must be correctly aligned otherwise a copy must be taken by slicing the underlyingArrayBuffer(in the@msgpack/msgpackpackage). Note, the Javascript library gives access to the encoder context for extension types but this is not available for this Python library.