Repository navigation
Reject negative lengths in Unpacker.read_bytes - #760
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unpacker.read_bytes()does not reject negative lengths. The C extension raises an internalSystemErrorfromPyBytes_FromStringAndSize; the Python implementation accepts the count and can return an unintended slice of buffered data.Raise
ValueErrorfor a negative byte count before reading or updating the stream position in either implementation. Four regression cases cover feed-based and file-based unpackers with-1and a larger negative count. They also check that the failed call leaves the position unchanged and that zero-length reads and subsequent reads/unpacking still work.On Windows/Python 3.13, all four cases fail with each unchanged implementation. With the fix, the complete C-extension suite has 164 passed and 1 skipped; the Python suite has 161 passed and 4 skipped. Both retain three existing unknown-marker warnings for
thread_unsafewhen the free-threaded test plugin is absent. Repository-wide Ruff lint and format checks pass. Other OS/Python and free-threaded matrices were not run locally.Related: #742 validates negative sizes in the packer header APIs; this change covers the unpacker's raw-byte reader. #752 concerns short feed-based reads, which is a separate case.
AI assistance: OpenAI Codex investigated, generated and self-reviewed the patch, and ran the local checks. No separate human review is claimed.