test(cli): transfer socket descriptor ownership - #12465
Merged
Merged
Conversation
Duplicate the socket descriptor before handing it to the activation helper. Close the original file to prevent its finalizer from closing a reused coverage descriptor after the helper closes its own file wrapper. Assisted-by: Codex:gpt-6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix repeated Linux coverage failures on gallery PRs, including #12464 and #12457. The socket activation test gives two
os.Fileobjects ownership of one descriptor. The helper closes it, then the original file's finalizer can close a reused coverage metadata descriptor (bad file descriptor).Duplicate the descriptor for the activation helper and explicitly close the original file.
Notes for Reviewers
A standalone reproduction using the actual activation helper fails before this change and keeps the reused descriptor open after it. The socket activation Ginkgo specs pass with coverage in an isolated harness. Full repository coverage CI remains to be verified; the coverage baseline is unchanged.
Signed commits