fix: allow warping players/peds to passenger seats on towed train carriages (#3025) - #5241
Open
MohabCodeX wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The actual logic change is only replacing the check with an early return for seat 0. The rest of the diff is just indentation cleanup
Fixes #3025
Test Plan
Run the following commands via
runcode:Spawn a train engine and attach a passenger carriage:
run train = Vehicle(538, 0, 0, 4) carriage = Vehicle(570, 0, 0, 4) attachTrailerToVehicle(train, carriage)Warp into passenger seat 1 of the towed carriage:
run warpPedIntoVehicle(me, carriage, 1)Expected result: Returns
trueand the player is warped inside the carriage seat.Verify driver seat (seat 0) on the towed carriage is disallowed:
run warpPedIntoVehicle(me, carriage, 0)Expected result: Returns
false.