Fix UV animated textures not working on custom loaded DFF models - #5275
Open
TheCrazy17 wants to merge 3 commits into
Open
Fix UV animated textures not working on custom loaded DFF models#5275TheCrazy17 wants to merge 3 commits into
TheCrazy17 wants to merge 3 commits into
Conversation
MatFX needs the per-material UV transform flag, not just the atomic one, and the UV anim dictionary chunk preceding the clump must be read before RpClumpStreamRead. Fixes both DFF loading paths.
ConvertBufferToObject, LoadAtomicFile's only native caller, already reads it; only ReadDFF's engineLoadDFF/engineReplaceModel path still needs it.
Member
|
Note for maintainers: please do not merge until I have approved |
FileEX
requested changes
Aug 28, 2026
Contributor
|
2026 is truly an epic year for MTA |
|
It could be even more epic, it's going to be legendary. |
Also makes the UV anim dict schema address constexpr.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the missing leading UV anim dictionary read to CRenderWareSA::ReadDFF, the path used by engineLoadDFF and engineReplaceModel, so custom loaded DFF models with UV animated textures play those animations instead of staying static.
https://streamable.com/08znl7 (Now you can use SA:MP animated objects, for example)
Motivation
ReadDFF opens its own stream and parses the clump directly, with no upstream code reading the leading UV anim dictionary chunk first. Native streaming already handles this in ConvertBufferToObject, but engineLoadDFF/engineReplaceModel never got the same treatment, so a custom loaded model with UV animated textures streamed in without ever setting the dictionary those animations need, leaving them static.
Fixes #5151
Test plan
Just replace any object with a model that has UV-animated textures.
uvbboards.zip
Checklist