Skip to content

Fix jacked players warping while being pulled out - #5283

Open
TheCrazy17 wants to merge 2 commits into
multitheftauto:masterfrom
TheCrazy17:fix/jacked-players-warps
Open

Fix jacked players warping while being pulled out#5283
TheCrazy17 wants to merge 2 commits into
multitheftauto:masterfrom
TheCrazy17:fix/jacked-players-warps

Conversation

@TheCrazy17

Copy link
Copy Markdown
Contributor

Summary

The exit confirmation can arrive while the victim's drag animation is still playing on clients watching it. The hard warp then cut it off and teleported him to the exit spot, the vehicle kept repositioning him to its center as one of its occupants, and his own position sync fought the fall.

The drag task now owns the ped until it ends: the warp guards recognize the jack task, the vehicle occupant updates leave out a ped who has physically left the car, and his position interpolation and under floor fix skip the same window.

The second commit covers the jacker cancelling after pulling the victim out; the victim leaves through the notify out path there, and the abort handler also warped him back into the vehicle as desynced mid animation.

Without fix: https://streamable.com/0zvdi5
With the fix: https://streamable.com/cc5v0t

Motivation

Fixes #1750.

Test plan

  1. With a second client watching, jack a player out of his vehicle.
  2. He should get dragged out, fall and stand up in one continuous animation; before this he flashed on the roof and flickered between the ground and the center of the car, lifting the vehicle.
  3. Repeat but walk away with WASD right after pulling him out instead of entering; before this he flashed at the center of the car for an instant.

Checklist

  • Your code should follow the coding guidelines.
  • Smaller pull requests are easier to review. If your pull request is beefy, your pull request should be reviewable commit-by-commit.

The exit confirmation can arrive while the victim's drag animation is
still playing on clients watching it; the hard warp cut it off, and
the vehicle occupant updates and his own position sync kept fighting
it. Let the drag task own the ped until it ends.
A jack victim leaves through the notify out path when the jacker
cancels the entry, and the abort handler itself warped him back into
the vehicle as desynced; both were missing the drag animation check.
@FileEX FileEX added sync bugfix Solution to a bug of any kind labels Aug 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Solution to a bug of any kind sync

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Player getting jacked is warped to roof of car

2 participants