Fix jacked players warping while being pulled out - #5283
Open
TheCrazy17 wants to merge 2 commits into
Open
Conversation
The exit confirmation can arrive while the victim's drag animation is still playing on clients watching it; the hard warp cut it off, and the vehicle occupant updates and his own position sync kept fighting it. Let the drag task own the ped until it ends.
A jack victim leaves through the notify out path when the jacker cancels the entry, and the abort handler itself warped him back into the vehicle as desynced; both were missing the drag animation check.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The exit confirmation can arrive while the victim's drag animation is still playing on clients watching it. The hard warp then cut it off and teleported him to the exit spot, the vehicle kept repositioning him to its center as one of its occupants, and his own position sync fought the fall.
The drag task now owns the ped until it ends: the warp guards recognize the jack task, the vehicle occupant updates leave out a ped who has physically left the car, and his position interpolation and under floor fix skip the same window.
The second commit covers the jacker cancelling after pulling the victim out; the victim leaves through the notify out path there, and the abort handler also warped him back into the vehicle as desynced mid animation.
Without fix: https://streamable.com/0zvdi5
With the fix: https://streamable.com/cc5v0t
Motivation
Fixes #1750.
Test plan
Checklist