Fix camera view modes not working while spectating - #5291
Open
TheCrazy17 wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GTA handles the change camera key inside CCamera::CamControl, but it stays dead while a script owns the camera, which is how setCameraTarget takes it: the cycle and click sound gates require a player owned camera, and the zoom easing follows leftover script zoom values that discard the index. While the camera follows a focused entity the client now opens those gates and clears the script zoom flags, so the native cycling runs untouched, and restores everything when the camera is released.
Refocusing between a ped and a vehicle is committed right after TakeControl, mirroring the jumpcut block CamControl uses, so the camera switches properly when the spectated player enters or leaves a vehicle.
The bumper and cinematic modes stay out: the cinematic system retargets using the local player, and the bumper view relies on the vehicle shell falling outside the near plane, which does not hold on remote vehicles. Spectating cycles through the three zoom levels. (Maybe we can fix or implement them later)
https://streamable.com/1l4hy5
Motivation
Fixes #669.
Test plan
Checklist