Skip to content

🚚 Vendor density-matrix DD support - #940

Merged
denialhaag merged 12 commits into
mainfrom
move-density-matrix-support
Aug 11, 2026
Merged

🚚 Vendor density-matrix DD support#940
denialhaag merged 12 commits into
mainfrom
move-density-matrix-support

Conversation

@denialhaag

@denialhaag denialhaag commented Aug 2, 2026

Copy link
Copy Markdown
Member

Description

munich-quantum-toolkit/core#1466 has removed density-matrix DD support in MQT Core. The changes will be released as part of version 4.0.0. This PR moves the relevant code to MQT DDSIM.

AI Notice

All changes are heavily assisted by Opus 4.8 and 5 via Claude Code.

Checklist

  • The pull request only contains commits that are focused and relevant to this change.
  • I have added appropriate tests that cover the new/changed functionality.
  • I have updated the documentation to reflect these changes.
  • I have added entries to the changelog for any noteworthy additions, changes, fixes, or removals.
  • I have added migration instructions to the upgrade guide (if needed).
  • The changes follow the project's style guidelines and introduce no new warnings.
  • The changes are fully tested and pass the CI checks.
  • I have reviewed my own code changes.

If PR contains AI-assisted content:

  • Any agent that created, edited, or submitted GitHub content was explicitly authorized for that scope, as required by our AI Usage Guidelines.
  • Every agent-authored or agent-edited public text body begins with the visible disclosure 🤖 *AI text below* 🤖 (titles are exempt).
  • I have disclosed AI assistance in the PR description.
  • I confirm that I have personally reviewed and understood all AI-generated content, and accept full responsibility for it.

@denialhaag denialhaag self-assigned this Aug 2, 2026
@denialhaag denialhaag added c++ Anything related to C++ code refactor Anything related to code refactoring labels Aug 2, 2026
@github-project-automation github-project-automation Bot moved this to In Progress in MQT Simulation Aug 2, 2026
@codecov

codecov Bot commented Aug 2, 2026

Copy link
Copy Markdown

@denialhaag
denialhaag force-pushed the move-density-matrix-support branch from 7f3902b to ea5aee0 Compare August 2, 2026 14:26

@burgholzer burgholzer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This likely requires an upgrade guide note as well.

Assisted-by: Claude Opus 4.8 via Claude Code
Assisted-by: Claude Opus 4.8 via Claude Code
@denialhaag
denialhaag force-pushed the move-density-matrix-support branch from ea5aee0 to a0fcf88 Compare August 2, 2026 14:48
Assisted-by: Claude Opus 4.8 via Claude Code
Assisted-by: Claude Opus 4.8 via Claude Code
Assisted-by: Claude Opus 4.8 via Claude Code
Assisted-by: Claude Opus 5 via Claude Code
Assisted-by: Claude Opus 5 via Claude Code
Assisted-by: Claude Opus 5 via Claude Code
Assisted-by: Claude Opus 5 via Claude Code
@denialhaag

Copy link
Copy Markdown
Member Author

@burgholzer, some changes since you last checked this:

  1. Added an entry to the upgrade guide.
  2. Copied over all tests that were removed in MQT Core so that coverage should be happy now.
  3. Removed dead code in d3b9c8f, all of which is part of the vendored code initially added in this PR. Is any of this needed, or can we do without it? If we want to keep it, I'd say we should at least cover it with tests. 🤔

Claude Code also built and tested against the merge commit for munich-quantum-toolkit/core#1466 to ensure this PR didn't miss anything.

Aside from the dead code point, I'd say we can merge this. 🤔

@burgholzer burgholzer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good to me 👍🏻 dead code can stay dead ☠️

@denialhaag
denialhaag marked this pull request as ready for review August 11, 2026 21:33
@denialhaag
denialhaag enabled auto-merge (squash) August 11, 2026 21:47
@denialhaag
denialhaag merged commit 39101e3 into main Aug 11, 2026
54 of 57 checks passed
@denialhaag
denialhaag deleted the move-density-matrix-support branch August 11, 2026 21:54
@github-project-automation github-project-automation Bot moved this from In Progress to Done in MQT Simulation Aug 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c++ Anything related to C++ code refactor Anything related to code refactoring

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants