Repository navigation
feat: add account_type field to ProductSearch for Rev 6 account_type filtering | MC-16677 - #408
Merged
Merged
Conversation
…filtering | MC-16677
SandhyaBhatia
requested review from
gerfboy,
mattnichols,
meotch,
stevecl5 and
tessstoddard
as code owners
October 8, 2026 20:37
gerfboy
approved these changes
Oct 8, 2026
tessstoddard
reviewed
Oct 8, 2026
mattnichols
approved these changes
Oct 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Adds an
account_typefield toProductSearchso MDX Product's list endpoint (GET /users/{user_id}/products?type=&account_type=) can bind and pass through theaccount_typequery parameter, per the Rev 6 MDX Product spec.Fixes MC-16677 (https://mxcom.atlassian.net/browse/MC-16677)
Public API Additions/Changes
ProductSearchgainsgetAccount_type()/setAccount_type(String).account_type(notaccountType) intentionally — this controller's query-param binding (ProductController#listProducts(ProductSearch)) does Spring's default property-name matching with no snake_case/camelCase conversion. Confirmed by existing precedent:TransactionSearchRequest.start_dateuses the same non-standard naming for the same reason (see its class comment).@SuppressWarnings({"checkstyle:MemberName", ...})was already present onProductSearchfor this purpose.Downstream Consumer Impact
productSearch.getAccount_type()to filter product lists by account type; accessors that don't use it are unaffected.path-accessor-central-pacific'sProductAccessor.list()will consume this field (tracked in MC-16678, separate PR).How Has This Been Tested?
./gradlew :mdx-models:test— all 575 existing tests pass../gradlew :mdx-models:compileJava :mdx-models:checkstyleMain— clean (only pre-existing unrelated deprecation warnings).ProductSearch,TransactionSearchRequest, etc. have none), so this follows existing convention.Checklist: