Repository navigation
style: fix spotless groovy formatting in MdxOnDemandMdxListSerializerTest - #410
Merged
Merged
Conversation
…Test Fixes a pre-existing closing-paren indentation violation flagged by spotlessGroovyCheck on master, unrelated to any recent feature change.
SandhyaBhatia
requested review from
gerfboy,
mattnichols,
meotch,
stevecl5 and
tessstoddard
as code owners
October 8, 2026 22:31
gerfboy
previously approved these changes
Oct 9, 2026
…altime Earlier commit only fixed mdx-models; a stale cached coppuccino plugin resolution (version 8.+) locally masked additional violations that CI's resolved plugin version caught in mdx-web and realtime test sources. Running with --refresh-dependencies reproduced CI's formatter output and surfaced/fixed all remaining violations: - ProductControllerTest.groovy - ProfilesControllerTest.groovy - RecurringTransfersControllerTest.groovy - MdxRealtimeMembersConnectionTest.groovy - MdxRealtimeUsersConnectionTest.groovy ./gradlew spotlessCheck now passes clean across all modules.
gerfboy
approved these changes
Oct 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Fixes a pre-existing
spotlessGroovyCheck(Groovy formatting) violation onmasterinMdxOnDemandMdxListSerializerTest.groovythat is currentlyfailing the
ci / buildworkflow onmaster:This is unrelated to recent feature work (confirmed via
git logthat thistest file hasn't been touched in recent commits/PRs) — it's drift that
started tripping CI on
master, which in turn is blocking thechore(master): release 23.5.0release-please PR (#409) from going outclean.
Fixes # (no tracked issue — internal CI hygiene fix)
Public API Additions/Changes
None — test-only whitespace/indentation change.
Downstream Consumer Impact
None — purely a formatting fix to a test file; no production code or
behavior changed.
How Has This Been Tested?
./gradlew :mdx-models:spotlessGroovyCheckpasses locally after the fix./gradlew :mdx-models:test— existing tests unaffected (no logic change)Checklist: