Fix production Turnstile "Could not complete bot check" - #331
Merged
Conversation
Production loads api.js with async, and Cloudflare throws if ready() is called on that script. The gate treated that throw as a failed challenge, so Run always showed "Could not complete bot check". Wait for render/execute instead; they are already enough. Co-authored-by: Max Schmitt <max@schmitt.mx>
mxschmitt
marked this pull request as ready for review
September 4, 2026 05:25
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Two production bugs after clicking Run on https://try.playwright.tech:
Error: Could not complete bot check. Please try again.Bot check
The frontend gate calls
turnstile.ready()afterapi.jshas already loaded withasync. Cloudflare throws:TurnstileError: [Cloudflare Turnstile] Remove async/defer from the Turnstile api.js script tag before using turnstile.ready().That throw is caught in
requestTokenand treated as an empty token, so the UI never starts the challenge.Fix: stop calling
turnstile.ready().waitForApi()already waits untilrenderandexecuteexist.Editor height
height: 100%on Grid/Row/Col does not resolve against Content's flex-inducedheight: auto. Layout is therefore content-sized. Examples are tall enough to look fine; a short error output collapses the grid to ~216px.Fix: fill Content → Grid → Row → columns with
flex: 1; min-height: 0instead of percentage heights.Tests
frontend:npx playwright test src/turnstile.spec.tsfrontend:npx playwright test src/components/App/index.spec.tsx— includes a new case that Run + short error keeps both columns viewport-tall