Keep editor full height when output is a short error - #332
Merged
Conversation
Percentage height on the Grid/Row/Cols does not resolve against Content's flex-induced auto height, so a short error output collapsed the playground to ~200px. Fill the shell with flex instead and assert the columns stay viewport-tall after a bot-check error. Co-authored-by: Max Schmitt <max@schmitt.mx>
mxschmitt
marked this pull request as ready for review
September 4, 2026 05:31
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Keep the Content/Grid/Row fill chain on Box props so a short error
does not collapse the editor. Leave only the html/body/#app height
reset, and use minh={{ xs: 500, md: 0 }} for the mobile editor.
Co-authored-by: Max Schmitt <max@schmitt.mx>
rsuite media-query style updates did not apply flex/minh at md, so
the editor stayed at the 500px xs floor. Use flex={1} on the fill
chain and a single max-width 767px rule for stacked columns.
Co-authored-by: Max Schmitt <max@schmitt.mx>
Production tsc type-checks component specs, and @playwright/test is not a frontend dependency. Import Page from playwright/test instead. Co-authored-by: Max Schmitt <max@schmitt.mx>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
On production, after Run fails with a short error, the editor clips and leaves a large empty region below. Grid/Row/Col used
height: 100%, which does not resolve against Content’s flex-inducedheight: auto, so the playground sized to the error content (~216px).Fix
Fill the shell with rsuite Box props (
flex={1},minh={0},display="flex",direction="column") instead of a layout stylesheet. Custom CSS is only:html/body/#appheight resetmax-width: 767pxeditor min-height so stacked mobile columns stay content-sizedCI
The frontend image build runs
tsc && vite build. The new layout spec importedPagefrom@playwright/test, which is not a frontend dependency, so Dockertscfailed with TS2307. The spec now importsPagefromplaywright/test.Tests
cd frontend && npx tsc --noEmit && npx playwright test src/components/App/index.spec.tsx --project=chromiumIncludes
editor column stays full height after a short output error.