Skip to content

Remove SecurityBuffer#value before redefining it in test_auth.rb #487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yyuu merged 1 commit into from
Nov 2, 2026
Merged

Remove SecurityBuffer#value before redefining it in test_auth.rb #487

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions test/test_auth.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,6 +135,7 @@ def data_size
@active && @value ? @value.size : 0
end

remove_method(:value) if method_defined?(:value)

@yyuu yyuu Nov 2, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was not actually included in #488. It'd be still worthwhile to accept this change.... 🤔

@yahonda yahonda Nov 2, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for checking. I've rebased this onto master and dropped the commits already covered by #488, so this pull request now only contains the SecurityBuffer#value change.

It removes the original method before redefining it, the same way data_size already is, to silence method redefined; discarding old value.

httpclient/test/test_auth.rb

Lines 133 to 136 in fb499dd

remove_method(:data_size) if method_defined?(:data_size)
def data_size
@active && @value ? @value.size : 0
end

def value
@value ||= ""
end
Expand Down