Repository navigation
Enable frozen-string checks across MRI and JRuby - #488
Merged
Merged
Conversation
Duplicate socket and PEM buffers before mutating them, and copy binary debug input before changing its encoding. Add regression coverage for buffer reads, certificate chains, and frozen or mutable debug input.
WEBrick HTTPS aliases HTTPRequest#parse when loaded. Loading it after our prepend aliases the patch itself, causing recursive request parsing and StackOverflowError on JRuby. Require HTTPS first so orig_parse retains the original parser. Verified with two full JRuby 10.1.2.0 / Temurin 25 test runs: 256 tests, no failures or errors, and no Ruby warnings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Enable frozen-string-literal checks across the MRI and JRuby CI matrix, and fix the JRuby buffer mutations exposed by those checks.
Changes
Validation