Repository navigation
Conversation
Collaborator
|
The mutation only happens with camelCase names like |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2970
inline()flips logical names in an arraytransitionPropertyby writing into the caller's array. After the first call the style object holds names that are already flipped for that direction. So the next RTL call keepsmarginLeftinstead ofmarginRight, a second call in the same direction returns an array instead of a string, and a frozen array throwsTypeError: Cannot assign to read only property '0'.On master (6885829):
Change
compiler/index.js: copy the array withoriginalValue.slice()before writing to it.atomic()already does the same with[...values].$FlowFixMe[cannot-write]comment. The copy is a writable array, so Flow reports the comment as unused.compiler-test.js: two new tests, run for LTR and RTL. One checks the input array is unchanged and the same object gives the right result for the other direction. One checks a frozen array works.Behavior changes
inline()no longer changes the caller'stransitionPropertyarray.transitionPropertyarray now works instead of throwing.Testing
npm run unit -- --ci --runInBand: 55 suites passed, 811 passed, 6 skipped.npm run flow: 0 errors, and 0 warnings with--include-warnings.npm run lintandnpm run format: clean. The pre-commitlint-stagedtasks pass on the changed files.Validated with Claude Opus 5.5.