Repository navigation
Improve SELECT/PERFORM/RETURN formatting - #86
Merged
Merged
Conversation
joelmukuthu
force-pushed
the
fix/select-and-return-formatting
branch
from
September 30, 2026 12:30
4ba2c0c to
67bffd6
Compare
nene
approved these changes
Oct 9, 2026
nene
left a comment
nene
left a comment
Owner
There was a problem hiding this comment.
Thanks. This looks good.
Sorry, for the delayed response. My life has been really busy lately.
Comment on lines
+307
to
+324
| it(`keeps single-column PERFORM with nested breaks on one line when it fits`, async () => { | ||
| expect( | ||
| await pretty( | ||
| dedent` | ||
| PERFORM some_function_name( | ||
| arg => 1 | ||
| ) | ||
| `, | ||
| { dialect: "plpgsql" }, | ||
| ), | ||
| ).toBe(dedent` | ||
| PERFORM some_function_name(arg => 1) | ||
| `); | ||
| }); | ||
|
|
||
| it(`breaks inside single-column function args without hanging PERFORM`, async () => { | ||
| await testPlpgsql(dedent` | ||
| PERFORM some_function_name( |
Owner
There was a problem hiding this comment.
These separate tests for PERFORM are quite unnecessary. Because PERFORM is essentially just a different keyword with which a SELECT-statement can start.
Really this single small test above these to check that PERFORM can be used instead of SELECT is quite enough.
nene
added a commit
that referenced
this pull request
Oct 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: