Prepare Learn first-touch capture and App handoffs - #3079
Draft
ktsaou wants to merge 1 commit into
Draft
Conversation
Document initial-page, SPA and App handoff integration and characterize actual Root, navbar and PostHog plugin behavior. Preserve production behavior while reader deployment, concurrency, identity and retention qualification remain open. Validation: 10 Root tests and four native plugin and navbar checks pass.
✅ Deploy Preview for netdata-docusaurus ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose and prerequisite
Prepare first-touch capture on Learn and bounded App handoffs using the existing versioned cookie.
Blocked by https://github.com/netdata/cloud-frontend/pull/5743 being merged and released. Keep draft. The reader contract is pinned to
3461255246041ad8c309e749973faaa53c716b55. Verify the deployed App reader and Website compatibility change https://github.com/netdata/website/pull/1383 before readiness; re-audit maintainer changes and merged baselines. No other capture-producer PR is a prerequisite.Included
FIRST-TOUCH-ATTRIBUTION.md.No production capture or handoff code is implemented yet. These tests characterize the gaps and protect existing behavior, not certify a repaired Learn producer.
Remaining implementation and readiness gates
Compatibility and scope
No extra cookie or persistent browser store, identity merge, historical evidence rewrite, generated-content/redirect-policy edit, Accounts/Pulsar mechanism, proxy or live setting change. Pre-JavaScript redirects require their separately approved owner changes.
Validation
10 Root tests and four native plugin/navbar checks pass using synthetic/intercepted inputs. No App source is vendored and no other repository is required by these tests. Runtime source is unchanged; production build and producer acceptance are not claimed for this preparation draft.
Summary by cubic
Adds a research-only design and baseline tests preparing Learn first-touch capture and App handoffs. No production capture code is implemented; the tests protect existing behavior, which writes no
nd_first_touchcookie and preserves Website cookies byte-identical across loads and SPA navigation.Scope
FIRST-TOUCH-ATTRIBUTION.mddocuments the bounded implementation plan and the unresolved concurrency, identity-persistence, and SDK-readiness gates.src/theme/Root/firstTouchBaseline.test.jsrenders the real Root component and asserts no cookie writes on direct entries, SPA transitions, or with an existing Website cookie.tests/first_touch_producer_baseline.test.mjsverifies navbar App links carry only internal campaign labels and characterizes the installedposthog-docusaurus@2.0.5SDK stub and droppedloadedcallback.netdata/cloud-frontend#5743 is required before capture can be enabled; the pinned reader contract is documented inFIRST-TOUCH-ATTRIBUTION.md.Written for commit cd75c40. Summary will update on new commits.