Harden handling of untrusted message content - #1
Merged
Merged
Conversation
Strip C0 and C1 control characters from message text, card fields and desktop notifications, and drop C1 controls from the whole frame, so other people's messages can't inject terminal escape sequences. Card HTML entities unescape one at a time so  can't produce a raw ESC. Only http and https links in cards become clickable, matching openURL. safeName strips leading dots so an attachment can't land as a dotfile, /save creates ~/Downloads instead of falling back to the home directory, and /open downloads into the user cache dir instead of a shared /tmp directory.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Strip C0 and C1 control characters from message text, card fields and desktop notifications, and drop C1 controls from the whole frame, so other people's messages can't inject terminal escape sequences. Card HTML entities unescape one at a time so � can't produce a raw ESC.
Only http and https links in cards become clickable, matching openURL.
safeName strips leading dots so an attachment can't land as a dotfile, /save creates ~/Downloads instead of falling back to the home directory, and /open downloads into the user cache dir instead of a shared /tmp directory.