Repository navigation
nut-scanner: suggest allow_duplicates for ambiguous USB devices - #3670
Open
user01010111 wants to merge 9 commits into
Open
user01010111 wants to merge 9 commits into
user01010111 wants to merge 9 commits into
Conversation
USB devices with missing or repeated identifiers can produce ambiguous ups.conf entries. Add a commented allow_duplicates suggestion for supported drivers, with a warning that the association between configured names and physical devices may change. Add a focused C regression test for scanner output and update the scanner manual and NEWS. Fixes networkupstools#2998. Developed with assistance from OpenAI Codex (gpt-6-astra). Signed-off-by: user01010111 <lapses.50.booster@icloud.com>
|
A ZIP file with standard source tarball and another tarball with pre-built docs for commit 42157f1 is temporarily available: NUT-tarballs-PR-3670.zip. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Document the observed attribute pairs and expected suggestion bitmask in the scanner display regression cases. Developed with assistance from OpenAI Codex (gpt-6-astra). Signed-off-by: user01010111 <lapses.50.booster@icloud.com>
jimklimov
added
enhancement
nut-scanner
USB-duplicate-devices
…ess questioned by different `make` implementations [networkupstools#3670] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
…efer to PR [networkupstools#3670] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
jimklimov
approved these changes
Oct 7, 2026
Member
|
Various minor compiler/linker complaints, including some missing flags for LIBNSS on systems that do not have those libs in common dirs. |
jimklimov
marked this pull request as draft
October 10, 2026 14:01
Cast the captured-output allocation explicitly for strict Clang builds. Pass the configured SSL libraries and runtime search path when linking the scanner display test, matching the existing scanner build rules. Developed with assistance from OpenAI Codex. Signed-off-by: user01010111 <lapses.50.booster@icloud.com>
user01010111
marked this pull request as ready for review
October 12, 2026 08:23
|
✅ Build nut 2.8.5.5898-master completed (commit b22f7969e9 by @jimklimov)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
USB devices with missing or repeated identifiers can produce ambiguous
ups.confentries. Add a commentedallow_duplicatessuggestion for supported drivers, with a warning that the association between configured names and physical devices may change.The check accounts for active selectors and reuses NUT's existing matching and comment support. The suggestion is advisory: users still need to check the matching expressions before enabling it.
Add a focused C regression test for scanner output and update the scanner manual and NEWS.
Fixes #2998.
Validation on Linux using synthetic discovery records: all 45 scanner-output cases pass; the unchanged code fails the 24 positive cases and passes the 21 controls. Clean parallel GCC build, Clang and GNU89 regression builds, ASan/UBSan with leak detection, and a scanner build with USB and regex support disabled pass. Project
make checkpasses all 14 compiled tests, alongside the existing script checks; an existing root-onlybecome_user()subcheck is skipped. The updated manual builds, andmake distcheck-lightpasses with the regression included in the distribution archive.Full spelling checks use a local supplementary dictionary for
kernel'sandfirmware's, both present in unchanged upstream documentation. The updated scanner manual passes with the standard project dictionary.Developed with assistance from OpenAI Codex (
gpt-6-astra).