Repository navigation
docs: say how to use <nc-viewer-file> in a Vue template - #171
Merged
Merged
Conversation
It is a custom element: Vue tries to resolve it as a component unless told, and some builds, as @nextcloud/vite-config, do not let an app tell it. Show both ways, and why the file is bound with .prop. Assisted-by: ClaudeCode:claude-opus-5-5 Signed-off-by: John Molakvoæ <14975046+skjnldsv@users.noreply.github.com>
skjnldsv
added
type: documentation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #171 +/- ##
=======================================
Coverage 91.99% 91.99%
=======================================
Files 54 54
Lines 4572 4572
Branches 989 989
=======================================
Hits 4206 4206
Misses 342 342
Partials 24 24 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
<nc-viewer-file>is a custom element, so Vue tries to resolve it as a component and warns unless told otherwise. Some builds, like @nextcloud/vite-config, don't let an app tell it. The README now shows both ways (isCustomElement, or<component :is>with the tag in a constant) and whyfileis bound with.prop. Came up on nextcloud/server#65753.👾 This pull request was assisted by Claude Code, commits carry an
Assisted-bytrailer.