Repository navigation
feat(images): show the file itself past the server's preview size - #172
Merged
Merged
Conversation
An admin can cap previews below the screen, and the picture then shows blurred. The server now advertises the cap, so a picture the browser can show is loaded whole when its preview would be smaller than the space. Assisted-by: ClaudeCode:claude-opus-5-5 Signed-off-by: John Molakvoæ <14975046+skjnldsv@users.noreply.github.com>
skjnldsv
added
type: enhancement
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #172 +/- ##
=======================================
Coverage 91.99% 91.99%
=======================================
Files 54 54
Lines 4572 4587 +15
Branches 989 997 +8
=======================================
+ Hits 4206 4220 +14
Misses 342 342
- Partials 24 25 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An admin can cap previews well below the screen size with
preview_max_x/preview_max_y. The viewer then shows a small preview stretched over the screen, so pictures look blurry. The server now sends that cap in its capabilities (nextcloud/server#65714). When the preview would be smaller than the space it fills, the viewer loads the file itself instead.This only applies to formats the browser can show on its own, and only when the share allows downloading. Older servers don't send the cap and keep the current behaviour.
Fixes nextcloud/viewer#3014
Not tried by hand on an instance with a low cap yet.
👾 This pull request was assisted by Claude Code, commits carry an
Assisted-bytrailer.