Skip to content

docs: a handler element is mounted again for each file - #173

Merged
skjnldsv merged 1 commit into
mainfrom
docs/handler-remount
Oct 22, 2026
Merged

skjnldsv merged 1 commit into
mainfrom
docs/handler-remount

Conversation

@skjnldsv

Copy link
Copy Markdown
Contributor

A handler author asked whether next/prev updates file on the mounted element, and how the viewer gets back to its loading state. It doesn't update it: every file gets a new element, and the viewer resets the spinner itself. The README hinted at this in one sentence. This spells it out next to the loaded docs.

👾 This pull request was assisted by Claude Code, commits carry an Assisted-by trailer.

Assisted-by: ClaudeCode:claude-opus-5-5
Signed-off-by: John Molakvoæ <14975046+skjnldsv@users.noreply.github.com>
@skjnldsv skjnldsv added this to the 2.0.0 milestone Oct 22, 2026
@skjnldsv skjnldsv added type: documentation 📖 Improvements or additions to documentation AI assisted 3. to review labels Oct 22, 2026
@skjnldsv skjnldsv self-assigned this Oct 22, 2026
@skjnldsv
skjnldsv requested a review from ShGKme October 22, 2026 14:42
@codecov

codecov Bot commented Oct 22, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.99%. Comparing base (bffa989) to head (a5a8c2e).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #173   +/-   ##
=======================================
  Coverage   91.99%   91.99%           
=======================================
  Files          54       54           
  Lines        4572     4572           
  Branches      989      989           
=======================================
  Hits         4206     4206           
  Misses        342      342           
  Partials       24       24           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@skjnldsv
skjnldsv enabled auto-merge October 22, 2026 14:47
@skjnldsv
skjnldsv merged commit 0780383 into main Oct 22, 2026
19 checks passed
@skjnldsv
skjnldsv deleted the docs/handler-remount branch October 22, 2026 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review AI assisted type: documentation 📖 Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants