Skip to content

fix(videos): stop offering MPEG and Flash video, which no browser reads - #175

Merged
skjnldsv merged 1 commit into
mainfrom
fix/drop-unplayable-video-mimes
Oct 23, 2026
Merged

skjnldsv merged 1 commit into
mainfrom
fix/drop-unplayable-video-mimes

Conversation

@skjnldsv

Copy link
Copy Markdown
Contributor

The video handler offered video/mpeg and video/x-flv, so those files opened in the player only to fail. Now they download instead. I checked with real files served with their real mime:

clip Chromium 156 Firefox 157
MPEG-1 / MPEG-2 .mpg error 4 error 4
H.264 / Sorenson .flv error 4 error 4
H.264 .mov plays plays
H.264 .mp4 plays plays

video/quicktime stays: .mov plays even though Chromium's canPlayType says it can't. Both lists now say what they are: mimes a file can carry whose format a browser plays on its own. Safari wasn't tested.

Fixes #46

👾 This pull request was assisted by Claude Code, commits carry an Assisted-by trailer.

Assisted-by: ClaudeCode:claude-opus-5-5
Signed-off-by: John Molakvoæ <14975046+skjnldsv@users.noreply.github.com>
@skjnldsv skjnldsv added this to the 2.0.0 milestone Oct 23, 2026
@skjnldsv skjnldsv added type: bug 🐛 Something isn't working AI assisted 3. to review labels Oct 23, 2026
@skjnldsv skjnldsv self-assigned this Oct 23, 2026
@codecov

codecov Bot commented Oct 23, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.03%. Comparing base (a9f253a) to head (28a20fe).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #175      +/-   ##
==========================================
- Coverage   92.03%   92.03%   -0.01%     
==========================================
  Files          54       54              
  Lines        4609     4607       -2     
  Branches     1002     1002              
==========================================
- Hits         4242     4240       -2     
  Misses        342      342              
  Partials       25       25              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@skjnldsv
skjnldsv merged commit bf78e93 into main Oct 23, 2026
18 checks passed
@skjnldsv
skjnldsv deleted the fix/drop-unplayable-video-mimes branch October 23, 2026 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review AI assisted type: bug 🐛 Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

What does browserSupportedMimes mean?

1 participant