Repository navigation
fix(videos): use live photo metadata for poster - #177
Open
bulungasdeveloper wants to merge 1 commit into
Open
bulungasdeveloper wants to merge 1 commit into
bulungasdeveloper wants to merge 1 commit into
Conversation
bulungasdeveloper
force-pushed
the
fix/livephoto-video-metadata
branch
from
October 23, 2026 19:48
a59c002 to
2976b01
Compare
Resolve a video's poster from the live photo metadata before falling back to the picture beside it. The metadata links both halves by file id, so a video whose picture has a different name still shows the right poster. Keep the name fallback for videos without metadata, but never pair a video with an image that belongs to another live photo. Assisted-by: opencode:deepseek-v4.1-flash-free Signed-off-by: Braux Martinez <martinezjb@hitss.com>
bulungasdeveloper
force-pushed
the
fix/livephoto-video-metadata
branch
from
October 23, 2026 20:06
2976b01 to
985573e
Compare
Author
|
Hi maintainers, |
Contributor
|
@bulungasdeveloper thanks for the PR! @artonge what do you think of that ? You have more knowledge than me on live photos metadata :)) |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #177 +/- ##
=======================================
Coverage 92.03% 92.04%
=======================================
Files 54 54
Lines 4607 4611 +4
Branches 1002 1005 +3
=======================================
+ Hits 4240 4244 +4
Misses 342 342
Partials 25 25 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A video and a picture with the same name are not necessarily halves of the same live photo.
Resolve the poster through the DAV live photo metadata when the video carries it, and keep the
name pairing only for videos without metadata. A picture that already belongs to another live
photo is not used as a poster by name.
This makes video poster resolution symmetric with the image path, which already uses metadata.
How to test
metadata-files-live-photo.Unit tests added in
__tests__/component/media.spec.tsand__tests__/utils.spec.ts.Checklist
eslint)mainAI