Repository navigation
fix(videos): say when the browser can't show a video's picture - #178
Merged
Merged
Conversation
Assisted-by: ClaudeCode:claude-opus-5-5 Signed-off-by: John Molakvoæ <14975046+skjnldsv@users.noreply.github.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #178 +/- ##
==========================================
- Coverage 92.03% 92.02% -0.01%
==========================================
Files 54 54
Lines 4607 4617 +10
Branches 1002 1006 +4
==========================================
+ Hits 4240 4249 +9
- Misses 342 343 +1
Partials 25 25 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A video whose codec the browser can't decode (HEVC in Chrome and Firefox on most systems, so most iPhone videos) loads without an error: the sound plays over a black screen, and nothing says why. Its metadata comes with no picture size, so the viewer now shows a small notice over the player and lets the sound play on.
It only shows for a video known to have a picture, from its preview or its MP4/MOV header, so a file with only sound gets no notice.
Fixes #108
Checked with an HEVC
.movin Chromium. A WebM or MKV without a preview has no header we read, so it gets no notice.👾 This pull request was assisted by Claude Code, commits carry an
Assisted-bytrailer.