Skip to content

fix(videos): say when the browser can't show a video's picture - #178

Merged
skjnldsv merged 1 commit into
mainfrom
fix/video-without-picture
Oct 24, 2026
Merged

skjnldsv merged 1 commit into
mainfrom
fix/video-without-picture

Conversation

@skjnldsv

Copy link
Copy Markdown
Contributor

A video whose codec the browser can't decode (HEVC in Chrome and Firefox on most systems, so most iPhone videos) loads without an error: the sound plays over a black screen, and nothing says why. Its metadata comes with no picture size, so the viewer now shows a small notice over the player and lets the sound play on.

It only shows for a video known to have a picture, from its preview or its MP4/MOV header, so a file with only sound gets no notice.

Fixes #108

Before After
before after

Checked with an HEVC .mov in Chromium. A WebM or MKV without a preview has no header we read, so it gets no notice.

👾 This pull request was assisted by Claude Code, commits carry an Assisted-by trailer.

Assisted-by: ClaudeCode:claude-opus-5-5
Signed-off-by: John Molakvoæ <14975046+skjnldsv@users.noreply.github.com>
@skjnldsv skjnldsv added this to the 2.0.0 milestone Oct 24, 2026
@skjnldsv skjnldsv added type: bug 🐛 Something isn't working AI assisted 3. to review labels Oct 24, 2026
@skjnldsv skjnldsv self-assigned this Oct 24, 2026
@codecov

codecov Bot commented Oct 24, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 92.02%. Comparing base (bf78e93) to head (cbca687).

Files with missing lines Patch % Lines
lib/components/Videos.vue 90.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #178      +/-   ##
==========================================
- Coverage   92.03%   92.02%   -0.01%     
==========================================
  Files          54       54              
  Lines        4607     4617      +10     
  Branches     1002     1006       +4     
==========================================
+ Hits         4240     4249       +9     
- Misses        342      343       +1     
  Partials       25       25              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@skjnldsv
skjnldsv merged commit 968f669 into main Oct 24, 2026
19 of 20 checks passed
@skjnldsv
skjnldsv deleted the fix/video-without-picture branch October 24, 2026 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review AI assisted type: bug 🐛 Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Say when a video's picture cannot be decoded

1 participant