fix(oc-file-list): favorite refresh

[alperozturk96]

Issue

Duplicated items is displayed after rename favorite file

Steps to reproduce

1. Mark file as favorite
2. Open favorite tab
3. Rename favorite file

Changes

• Fixes the issue by always setting up-to-date cached then remote files properly
• Fixes refresh after rename
• Fixes refresh after delete
• Fixes resetting layout after rename
• Fixes loading state after rename for search task
• Simplifies rename logic via early exits and separate functions
• Add comments to understand flow better

[github-actions]

APK file: https://github.com/nextcloud/android/actions/runs/25664115298/artifacts/6916208022
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
(please click on link to get QR code displayed)

[github-actions]

APK file: https://github.com/nextcloud/android/actions/runs/25673926941/artifacts/6920944020
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
(please click on link to get QR code displayed)

[github-actions]

APK file: https://github.com/nextcloud/android/actions/runs/26213558275/artifacts/7130546129
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
(please click on link to get QR code displayed)

pr is updated

[Copilot]

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Fixes duplicate/incorrect items and refresh behavior in the Favorites file list (especially after rename/delete) by improving cached vs remote search handling and making layout preferences independent per root tab.

Changes:

• Refactors OCFileListSearchTask to load sorted cached items first, then refresh from remote and update adapter deterministically.
• Introduces FolderLayout and updates layout preference storage to distinguish All files / Favorites / Shared roots.
• Adjusts rename/delete flows to refresh UI more consistently and avoids duplicate “virtual” insertions.

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
app/src/main/java/com/owncloud/android/ui/fragment/OCFileListSearchTask.kt	Refactors cached/remote search flow; changes sorting and virtual file handling.
app/src/main/java/com/owncloud/android/ui/fragment/OCFileListFragment.java	Tweaks initial loading state behavior and updates grid/list preference call site.
app/src/main/java/com/owncloud/android/ui/fragment/FolderLayout.kt	Adds a sealed type to key layout preferences by root tab vs child folder.
app/src/main/java/com/owncloud/android/ui/fragment/FileListLayoutManager.kt	Switches layout preference logic to use FolderLayout; adjusts grid span logic.
app/src/main/java/com/owncloud/android/ui/dialog/RenameFileDialogFragment.kt	Simplifies rename logic with early returns; refactors target file variable.
app/src/main/java/com/owncloud/android/ui/adapter/OCFileListAdapter.java	Changes adapter update semantics; adds removeFile; removes addVirtualFile.
app/src/main/java/com/owncloud/android/ui/activity/FileDisplayActivity.kt	Updates empty-state handling and refactors rename/delete finish handling.
app/src/main/java/com/nextcloud/client/preferences/AppPreferencesImpl.java	Stores layout preferences by FolderLayout (root tabs per-account, child folders legacy).
app/src/main/java/com/nextcloud/client/preferences/AppPreferences.java	Updates layout preference API to accept FolderLayout.

Comments suppressed due to low confidence (1)

app/src/main/java/com/owncloud/android/ui/fragment/OCFileListSearchTask.kt:1

• sortSearchData now directly calls fragment.adapter.setSortOrder(sortOrder). In this PR, sortSearchData(...) is invoked from IO/background execution paths (e.g., inside the Dispatchers.IO job and loadSortedCachedDbFiles), which risks mutating UI/adapter state off the main thread. Make sortSearchData pure (only sort/return values) and apply setSortOrder(...) on the main thread (or return the resolved sortOrder alongside the sorted list).

/*

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[github-actions]

APK file: https://github.com/nextcloud/android/actions/runs/26217725410/artifacts/7133299769
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
(please click on link to get QR code displayed)

[Copilot]

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 4 comments.

[github-actions]

APK file: https://github.com/nextcloud/android/actions/runs/26225419392/artifacts/7135596855
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
(please click on link to get QR code displayed)

[github-actions]

APK file: https://github.com/nextcloud/android/actions/runs/26273560952/artifacts/7154808323
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
(please click on link to get QR code displayed)

[github-actions]

Codacy

SpotBugs

Category	Base	New
Bad practice	35	35
Correctness	67	67
Dodgy code	216	216
Experimental	1	1
Internationalization	7	7
Malicious code vulnerability	2	2
Multithreaded correctness	34	34
Performance	42	41
Security	16	16
Total	420	419

[github-actions]

APK file: https://github.com/nextcloud/android/actions/runs/26275274437/artifacts/7155548413
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
(please click on link to get QR code displayed)

[github-actions]

blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed.