[hannesa2]

I was investigation how to change Wifi upload mechanism, and I found that causing class is still Java 👎
So I converted it in advance to Kotlin without changing anything in the logic. I hope that tests will check, if there is something now faulty

[github-actions]

APK file: https://github.com/nextcloud/android/actions/runs/27058366047/artifacts/7453194578
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
(please click on link to get QR code displayed)

[github-actions]

APK file: https://github.com/nextcloud/android/actions/runs/27059364136/artifacts/7453518059
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
(please click on link to get QR code displayed)

[github-actions]

Codacy

SpotBugs

Category	Base	New
Bad practice	33	31
Correctness	67	64
Dodgy code	215	202
Experimental	1	1
Internationalization	7	7
Malicious code vulnerability	2	2
Multithreaded correctness	31	26
Performance	41	37
Security	16	16
Total	413	386

[github-actions]

APK file: https://github.com/nextcloud/android/actions/runs/27059855267/artifacts/7453666242
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
(please click on link to get QR code displayed)

[github-actions]

blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed.

[github-actions]

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

[alperozturk96]

Thanks for working on this.

I'd be more comfortable taking an incremental approach, for example, first extracting smaller pieces into separate Kotlin classes and then gradually converting the remaining parts. That would make the changes easier to review, test, and debug if anything goes wrong.

[hannesa2]

@alperozturk96 After 5 weeks. you want to multiply the afford here by splitting it in smaller junks.
As this is just the output of

you should re-think your comfortable it's-better-for-me-way

[tobiasKaminsky]

@hannesa2

Alper and me discussed this and to put it in bigger context, we struggle a bit with "automatic" java -> kotlin conversions, especially when it comes to big/central classes that are not easy to test manually (in opposite to UI related classes).
So my/our idea is now to test with your PR

• check code coverage of old java file
• add missing tests
• test tests with your migrated code
• some test

This will help us, not only for this PR, but also for upcoming semi/automated code conversions to see if this approach works.

I wanna thank you for helping with this project and PR 🎉

[alperozturk96]

It seems like the following cases are currently missing on master and would be good to have covered before the Kotlin conversion:

• FileUploaderIT doesn't seem to be used. Already contains tests for UploadFileOperation.
• UploadIT covers some UploadFileOperation scenarios, but not all combinations.
• The constructor guards in UploadFileOperation aren't tested.
• The encryptedUpload path isn't covered.
• The early return cases are missing as well (e.g. TextUtils.isEmpty(getStoragePath()), !localFile.exists(), etc.).
• I also couldn't find tests covering methods like obtainNewOCFileToUpload, getNewAvailableRemotePath, existsFile, and createNewOCFile.

Since this class is responsible for all uploads (AutoUpload, normal upload, etc.).

[hannesa2]

I wanna thank you for helping with this project and PR 🎉

@tobiasKaminsky I want to tell my my frustration. I made this, I didn't changed anything on the logic and it was working for me. But as it is not yours, you all put the brake and hesitate to accept it. -Ok, it's your choice-

But what does this mean for me ? It was just an intermediate step for me to solving an other (later) issue. But as this is not accepted, and dedicated to be pointless and to die, I stopped my afford to Nextcloud complete and unfortunately I've to keep on ownCloud. But the good thing for, there is the situation the same bad one.

Looks like a common behaviour "I/we know it better", so it's better to do nothing instead of moving forward.

Btw, you have at least a lot of CI test, but as they fail and nobody takes care about it and ignores them, this all CI checks are complete pointless and just waste of time of everyone.