[alperozturk96]

Implements:

App's shows a banner if device is in power save mode and this affects the auto upload behaviour such as delays.

This PR adds "Sync now" button inside the banner to re-trigger auto upload via bypassing the battery optimization.

#7019

[github-actions]

master-IT test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/17396-IT-master-08-57

[rain1]

Can this button be accessed also without putting phone in power save mode?

[alperozturk96]

Can this button be accessed also without putting phone in power save mode?

No and this button only re-trigger auto upload via bypassing the battery optimization. It does not ignore every check and try to force upload every file.

[github-actions]

APK file: https://github.com/nextcloud/android/actions/runs/31572128059/artifacts/9131895982
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
(please click on link to get QR code displayed)

[rain1]

APK file: https://github.com/nextcloud/android/actions/runs/31572128059/artifacts/9131895982 To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app. (please click on link to get QR code displayed)

It says 404 when visiting mobile browser, even when I request desktop site.

[github-actions]

APK file: https://github.com/nextcloud/android/actions/runs/32000183161/artifacts/9278348478
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
(please click on link to get QR code displayed)

[github-actions]

APK file: https://github.com/nextcloud/android/actions/runs/32222236432/artifacts/9354451949
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
(please click on link to get QR code displayed)

[github-actions]

APK file: https://github.com/nextcloud/android/actions/runs/32260099087/artifacts/9368106934
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
(please click on link to get QR code displayed)

[github-actions]

APK file: https://github.com/nextcloud/android/actions/runs/32261113774/artifacts/9368853506
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
(please click on link to get QR code displayed)

[github-actions]

APK file: https://github.com/nextcloud/android/actions/runs/32365959689/artifacts/9405461598
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
(please click on link to get QR code displayed)

[github-actions]

APK file: https://github.com/nextcloud/android/actions/runs/32368304545/artifacts/9406869650
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
(please click on link to get QR code displayed)

[github-actions]

APK file: https://github.com/nextcloud/android/actions/runs/32455639091/artifacts/9437278191
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
(please click on link to get QR code displayed)

[github-actions]

APK file: https://github.com/nextcloud/android/actions/runs/32458705183/artifacts/9438313833
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
(please click on link to get QR code displayed)

[github-actions]

APK file: https://github.com/nextcloud/android/actions/runs/32460236194/artifacts/9438834797
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
(please click on link to get QR code displayed)

[github-actions]

APK file: https://github.com/nextcloud/android/actions/runs/32465338188/artifacts/9440607044
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
(please click on link to get QR code displayed)

[github-actions]

Codacy

SpotBugs

Category	Base	New
Bad practice	32	32
Correctness	59	59
Dodgy code	207	207
Experimental	1	1
Malicious code vulnerability	2	2
Multithreaded correctness	25	25
Performance	39	39
Security	19	19
Total	384	384

[github-actions]

blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed.

[daniele-verducci]

Hey, tested last version that checks if the job is still running and works as intended. ✅
Definitely an upgrade!

[regs01]

@alperozturk96
You marked #7019 as completed with this MR, but it is unrelated.

[alperozturk96]

@alperozturk96 You marked #7019 as completed with this MR, but it is unrelated.

The feature request is related to “When putting Android into power saver mode, add a ‘force upload/sync’ button to automatic uploads”, but it should not be interpreted as a request to add a “force upload/sync” button to automatic uploads in general.

As the user described, they need to exit power saver mode first, after which the automatic upload will be triggered. Therefore, this issue is specifically related to the worker exiting early due to power management limitations.

The force button should only bypass the power management limitation of the worker, rather than bypassing all other limitations or restrictions.

[regs01]

@alperozturk96 You marked #7019 as completed with this MR, but it is unrelated.

The force button should only bypass the power management limitation of the worker, rather than bypassing all other limitations or restrictions.

#7019 wasn't about bypassing powersaving, but about havinmg manually trigger autoupload on demand in general. Powersaving was just an example of one of many instances, when it needed. Most issues about auto autoupload on demand button were closed as duplicate of #7019 - #13923, #11448, #16241, #582, #818, #16354 etc. This MR doesn't add that button. It only allowing bypass powersaving when autoupload already initiated itself.

[rain1]

@alperozturk96 You marked #7019 as completed with this MR, but it is unrelated.

The force button should only bypass the power management limitation of the worker, rather than bypassing all other limitations or restrictions.

#7019 wasn't about bypassing powersaving, but about havinmg manually trigger autoupload on demand in general. Powersaving was just an example of one of many instances, when it needed. Most issues about auto autoupload on demand button were closed as duplicate of #7019 - #13923, #11448, #16241, #582, #818, #16354 etc. This MR doesn't add that button. It only allowing bypass powersaving when autoupload already initiated itself.

I find it interesting how much effort NC developers are willing put in to avoid doing what users actually want. If all that time that have been spent on marking issues duplicates had be invested in implementation instead, not only would that button be there but also all the bugs would have been fixed by now.

[lntegrity]

Good morning. I updated from 34.1.1 to 35.0 last night (whatever is the latest in F-Droid).

I keep my phone on Power Save at all times. I've configured my library so some folders wait for Power Save before auto-uploading, and others don't.

When I woke up this morning, EVERY folder (including those previously flagged for Wait For Power Save) had uploaded to my NextCloud. Now I have to go and delete all the unwanted files, clean up the metadata, etc. I intentionally DON'T upload every file instantly, because I do tasks locally on my phone first, like metadata tagging, editing dates, moving to subfolders, etc). So this just cost me hours of work.

Further, the "Wait for Power Save" flag/checkbox is gone from the folder > Auto Upload settings.

Is this intentional? I literally hit "Update all apps" in F-Droid and went to sleep, so I never saw, nor pushed, any "Force Update" button. So why did I awake to NextCloud auto-uploading everything that was pending, despite Power Save being enabled, and despite not pushing a Force Update button? And why is the Power Save setting missing (replaced, apparently, with "Only upload when charging" which is very much not the same feature)?

And I hesitate to uninstall 35 and reinstall 34.1.1, because I don't want to trash my configuration and have to re-configure all the folder settings with respect to the auto-upload flag. Though I fear that setting may have been erased anyway...?

Thank you...

EDIT: Adding @alperozturk96 , @daniele-verducci - Sorry if @mentioning is inappropriate, figured I'd keep visibility within this existing PR instead of creating something new. Please let me know if I should go another route.