Skip to content

fix(upload): use supported transports - #17501

Merged
alperozturk96 merged 2 commits into
masterfrom
fix/network-constraits
Sep 15, 2026
Merged

fix(upload): use supported transports#17501
alperozturk96 merged 2 commits into
masterfrom
fix/network-constraits

Conversation

@alperozturk96

@alperozturk96 alperozturk96 commented Aug 18, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Fixes: #17500

@alperozturk96 alperozturk96 added this to the Nextcloud App 35.0.0 milestone Aug 18, 2026
@alperozturk96 alperozturk96 linked an issue Aug 18, 2026 that may be closed by this pull request
FileUploadWorker relies on public internet #17500
Closed
@alperozturk96 alperozturk96 mentioned this pull request Aug 18, 2026
Closed
@github-actions

github-actions Bot commented Aug 18, 2026

Copy link
Copy Markdown

APK file: https://github.com/nextcloud/android/actions/runs/32143782620/artifacts/9331015312
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@github-actions

github-actions Bot commented Sep 9, 2026

Copy link
Copy Markdown

APK file: https://github.com/nextcloud/android/actions/runs/34332541709/artifacts/10097069521
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@github-actions

github-actions Bot commented Sep 9, 2026

Copy link
Copy Markdown

blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed.

daniele-verducci
daniele-verducci approved these changes Sep 15, 2026
View reviewed changes

@daniele-verducci daniele-verducci left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Alper,
tried to reproduce the original issue using docker, the emulator and disconnecting my computer from the internet, but the app on master still uploaded the files...
Anyway, I went on and tested this PR and the upload works correctly. I just wasn't able to prove it actually fixes the original issue, as I wasn't able to reproduce it.

@alperozturk96
fix(upload): use supported transports
2b83d96 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>

# Conflicts:
#	app/src/main/java/com/nextcloud/client/network/ConnectivityServiceImpl.kt
@alperozturk96
wip
af4df95 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@codecov

codecov Bot commented Sep 15, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 82.14286% with 5 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...extcloud/client/network/ConnectivityServiceImpl.kt 33.33% 1 Missing and 1 partial ⚠️
...cloud/client/network/SupportedNetworkTransports.kt 91.30% 1 Missing and 1 partial ⚠️
.../nextcloud/client/jobs/BackgroundJobManagerImpl.kt 50.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@github-actions

github-actions Bot commented Sep 15, 2026

Copy link
Copy Markdown

Codacy

SpotBugs

CategoryBaseNew
Bad practice3232
Correctness5858
Dodgy code186186
Experimental11
Malicious code vulnerability22
Multithreaded correctness2626
Performance3737
Security1919
Total361361

@alperozturk96

alperozturk96 commented Sep 15, 2026

Copy link
Copy Markdown
Collaborator Author

/backport to stable-35.0.x

@github-actions

github-actions Bot commented Sep 15, 2026

Copy link
Copy Markdown

📱 QA build
Download app-qa-debug.apk (512)
QR code Open the QR code for this download
Commit af4df95
Version 17501
Available until 7 days after this build

The QA build installs alongside a released Nextcloud app, so you can keep
using your existing install while testing.

Downloading the file requires a GitHub account, so open this link on the
device you want to test on, or transfer the APK to it.

@alperozturk96
alperozturk96 merged commit f50eaf4 into master Sep 15, 2026
27 of 30 checks passed
@alperozturk96
alperozturk96 deleted the fix/network-constraits branch September 15, 2026 15:44
@backportbot backportbot Bot mentioned this pull request Sep 15, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@daniele-verducci daniele-verducci daniele-verducci approved these changes
@tobiasKaminsky tobiasKaminsky Awaiting requested review from tobiasKaminsky

Assignees

No one assigned

Labels

3. to review

Projects

None yet

Milestone

Nextcloud App 35.0.2

Development

Successfully merging this pull request may close these issues.

FileUploadWorker relies on public internet

2 participants

@alperozturk96 @daniele-verducci