Repository navigation
Fix missing local path for autouploaded files - #17522
daniele-verducci wants to merge 1 commit into
Conversation
… autoupload to have theirs filelist.media_path populated so they can be retrieved using FileDao.getFileByLocalPath() Signed-off-by: daniele-verducci <daniele.verducci@nextcloud.com>
|
master-IT test failed, but no output was generated. Maybe a preliminary stage failed. |
|
blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed. |
|
APK file: https://github.com/nextcloud/android/actions/runs/32853041783/artifacts/9567479377 |
|
After discussing it with @tobiasKaminsky , we found this is technically wrong, that field is meant for the files in the app's own paths and would have unwanted consequences if filled with external paths. |
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
Files uploaded by autoupload do not have their filelist.media_path column populated in the db.
That is not the case for other workflows (i.e. manually uploading a single file).
This field allows them to be retrieved using FileDao.getFileByLocalPath(), in other words makes possible to reconstruct a file's origin.
The consequences of this change are still to be discussed, so marking as Draft.
🏁 Checklist
/backport to stable-xx.x🤖 AI (if applicable)