Skip to content

Fix missing local path for autouploaded files - #17522

Closed
daniele-verducci wants to merge 1 commit into
masterfrom
fix/no-local-path-for-autouploaded-files
Closed

daniele-verducci wants to merge 1 commit into
masterfrom
fix/no-local-path-for-autouploaded-files

Conversation

@daniele-verducci

Copy link
Copy Markdown
Contributor

Files uploaded by autoupload do not have their filelist.media_path column populated in the db.
That is not the case for other workflows (i.e. manually uploading a single file).
This field allows them to be retrieved using FileDao.getFileByLocalPath(), in other words makes possible to reconstruct a file's origin.
The consequences of this change are still to be discussed, so marking as Draft.

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

🤖 AI (if applicable)

  • The content of this PR was partly or fully generated using AI

… autoupload to have theirs filelist.media_path populated so they can be retrieved using FileDao.getFileByLocalPath()

Signed-off-by: daniele-verducci <daniele.verducci@nextcloud.com>
@github-actions

Copy link
Copy Markdown

master-IT test failed, but no output was generated. Maybe a preliminary stage failed.

@github-actions

Copy link
Copy Markdown

blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed.

@github-actions

Copy link
Copy Markdown

APK file: https://github.com/nextcloud/android/actions/runs/32853041783/artifacts/9567479377
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@github-actions

Copy link
Copy Markdown

Codacy

SpotBugs

CategoryBaseNew
Bad practice3232
Correctness5959
Dodgy code207207
Experimental11
Malicious code vulnerability22
Multithreaded correctness2525
Performance3939
Security1919
Total384384

@daniele-verducci

Copy link
Copy Markdown
Contributor Author

After discussing it with @tobiasKaminsky , we found this is technically wrong, that field is meant for the files in the app's own paths and would have unwanted consequences if filled with external paths.
So I discard this PR, the discussion can continue on the relevant issue: #12967

@daniele-verducci
daniele-verducci deleted the fix/no-local-path-for-autouploaded-files branch August 26, 2026 08:56
@github-actions

github-actions Bot commented Sep 9, 2026

Copy link
Copy Markdown

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant