Repository navigation
improve: fetch-template - #17569
Merged
Merged
improve: fetch-template#17569
Conversation
alperozturk96
force-pushed
the
refactor/fetch-template
branch
from
September 7, 2026 09:58
04a5377 to
b3c6bf8
Compare
Collaborator
Author
|
/backport to stable-35.0.x |
alperozturk96
force-pushed
the
refactor/fetch-template
branch
from
September 10, 2026 09:16
b3c6bf8 to
0442a1e
Compare
daniele-verducci
approved these changes
Sep 14, 2026
daniele-verducci
left a comment
daniele-verducci
left a comment
Contributor
There was a problem hiding this comment.
Oh I noted the interaction on the creator popup was a little rough, very nice improvement! Thx!
alperozturk96
force-pushed
the
refactor/fetch-template
branch
from
September 14, 2026 17:26
0442a1e to
669a498
Compare
|
blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed. |
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
|
stable22-IT test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/17569-IT-stable22-17-57 |
The redundant elvis on fileNames belongs to neither the crash fix nor the Kotlin conversion, so it goes back to its previous form to keep this branch scoped to one concern. Assisted-by: ClaudeCode:claude-opus-5
When the template list comes back empty the dialog had no selected template, so the extension check compared the typed name against null and reported "Extension cannot be changed" for every name while Create stayed disabled. Resolve the filename into a single state, treat "no template selected" as its own state, hold the error back until the user has typed, and close the dialog when no template could be loaded. Assisted-by: ClaudeCode:claude-opus-5
Fail-fast control flow, JSON node names as constants, and URL building and response parsing split into separate functions. Behaviour is unchanged. Assisted-by: ClaudeCode:claude-opus-5
alperozturk96
force-pushed
the
refactor/fetch-template
branch
from
September 15, 2026 11:19
669a498 to
f290682
Compare
📱 QA build
The QA build installs alongside a released Nextcloud app, so you can keep Downloading the file requires a GitHub account, so open this link on the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
TemplateFilenameStateinstead of booleanshasUserInteractedguard helps to prevent error shown before the user typesFetchTemplateOperationto Kotlin