Repository navigation
Improve QA APK Action #17611
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Improve QA APK Action #17611
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
7d9d40e
wip
alperozturk96 a6a7eb4
test upsert
alperozturk96 933c550
test upsert 2
alperozturk96 691f202
create qr code
alperozturk96 96cb943
Try generating QR locally as UTF8 text
daniele-verducci bbe77bf
Inverted qr
daniele-verducci 9c07c50
Changed output format
daniele-verducci d4a7c38
Passing qr string with parenthesis
daniele-verducci 2b9c190
Urlencode multiline string
daniele-verducci ff652fc
Do not wrap encoded string
daniele-verducci d7696ea
wip
alperozturk96 449d1c3
try ASCII
alperozturk96 49a99d8
use link for qr code
alperozturk96 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -37,6 +37,7 @@ jobs: | |
| java-version: 21 | ||
|
|
||
| - name: Build QA | ||
| id: build-qa | ||
| if: ${{ steps.check-secrets.outputs.ok == 'true' }} | ||
| env: | ||
| KS_PASS: ${{ secrets.KS_PASS }} | ||
|
|
@@ -46,40 +47,70 @@ jobs: | |
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
| run: | | ||
| mkdir -p "$HOME/.gradle" | ||
| echo "org.gradle.jvmargs=-Xmx3g -XX:+HeapDumpOnOutOfMemoryError -Dfile.encoding=UTF-8 -XX:+UseParallelGC -XX:MaxMetaspaceSize=1g" > "$HOME/.gradle/gradle.properties" | ||
| echo "org.gradle.caching=true; org.gradle.parallel=true; org.gradle.configureondemand=true" >> "$HOME/.gradle/gradle.properties" | ||
| { | ||
| echo "org.gradle.jvmargs=-Xmx3g -XX:+HeapDumpOnOutOfMemoryError -Dfile.encoding=UTF-8 -XX:+UseParallelGC -XX:MaxMetaspaceSize=1g" | ||
| echo "org.gradle.caching=true" | ||
| echo "org.gradle.parallel=true" | ||
| echo "org.gradle.configureondemand=true" | ||
| } > "$HOME/.gradle/gradle.properties" | ||
| [ -e app/build.gradle ] && sed -i "/qa/,/\}/ s/versionCode .*/versionCode ${{github.event.number}} /" "app/build.gradle" | ||
| [ -e app/build.gradle ] && sed -i "/qa/,/\}/ s/versionName .*/versionName \"${{github.event.number}}\"/" "app/build.gradle" | ||
| [ -e app/build.gradle.kts ] && sed -i "/qa/,/\}/ s/versionCode .*/versionCode = ${{github.event.number}} /" "app/build.gradle.kts" | ||
| [ -e app/build.gradle.kts ] && sed -i "/qa/,/\}/ s/versionName .*/versionName = \"${{github.event.number}}\"/" "app/build.gradle.kts" | ||
| ./gradlew assembleQaDebug | ||
| $(find /usr/local/lib/android/sdk/build-tools/*/apksigner | sort | tail -n1) sign --ks-pass pass:"$KS_PASS" --key-pass pass:"$KEY_PASS" --ks-key-alias key0 --ks ".github/workflows/QA_keystore.jks" app/build/outputs/apk/qa/debug/*qa-debug*.apk | ||
| apk=$(find app/build/outputs/apk/qa/debug -name '*qa-debug*.apk' | head -n1) | ||
| echo "apk-path=$apk" >> "$GITHUB_OUTPUT" | ||
| echo "apk-name=$(basename "$apk")" >> "$GITHUB_OUTPUT" | ||
| echo "apk-size=$(du -h "$apk" | cut -f1)" >> "$GITHUB_OUTPUT" | ||
|
|
||
| - name: Upload APK | ||
| id: upload-apk | ||
| if: ${{ steps.check-secrets.outputs.ok == 'true' }} | ||
| uses: actions/upload-artifact@bbbca2ddaa5d8feaa63e36b76fdaad77386f024f | ||
| with: | ||
| path: app/build/outputs/apk/qa/debug/*qa-debug*.apk | ||
| path: ${{ steps.build-qa.outputs.apk-path }} | ||
| if-no-files-found: error | ||
| retention-days: 7 | ||
| archive: false | ||
|
|
||
| - name: Create QR Code | ||
| - name: Create QR code | ||
| if: ${{ steps.check-secrets.outputs.ok == 'true' }} | ||
| env: | ||
| ARTIFACT_URL: ${{ steps.upload-apk.outputs.artifact-url }} | ||
| run: | | ||
| sudo apt-get -y install qrencode | ||
| qrencode -o qr.png "${{ steps.upload-apk.outputs.artifact-url }}" | ||
| qrencode -s 8 -o qr.png "$ARTIFACT_URL" | ||
|
|
||
| - name: Upload QR | ||
| - name: Upload QR code | ||
| id: upload-qr | ||
| if: ${{ steps.check-secrets.outputs.ok == 'true' }} | ||
| uses: actions/upload-artifact@bbbca2ddaa5d8feaa63e36b76fdaad77386f024f | ||
| with: | ||
| path: qr.png | ||
| if-no-files-found: error | ||
| retention-days: 7 | ||
| archive: false | ||
|
|
||
| - name: Comment PR | ||
| if: ${{ steps.check-secrets.outputs.ok == 'true' }} | ||
| uses: thollander/actions-comment-pull-request@e4a76dd2b0a3c2027c3fd84147a67c22ee4c90fa | ||
| with: | ||
| comment-tag: qa-apk | ||
| mode: upsert | ||
|
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Instead of creating another comment, it edits/replaces that comment with the new message. |
||
| message: | | ||
| APK file: ${{ steps.upload-apk.outputs.artifact-url }} | ||
| To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app. | ||
|  (please click on link to get QR code displayed) | ||
| ### :iphone: QA build | ||
|
alperozturk96 marked this conversation as resolved.
|
||
|
|
||
| | | | | ||
| |---|---| | ||
| | **Download** | [${{ steps.build-qa.outputs.apk-name }}](${{ steps.upload-apk.outputs.artifact-url }}) (${{ steps.build-qa.outputs.apk-size }}) | | ||
| | **QR code** | [Open the QR code for this download](${{ steps.upload-qr.outputs.artifact-url }}) | | ||
| | **Commit** | ${{ github.event.pull_request.head.sha }} | | ||
| | **Version** | `${{ github.event.number }}` | | ||
| | **Available until** | 7 days after this build | | ||
|
|
||
| The QA build installs alongside a released Nextcloud app, so you can keep | ||
| using your existing install while testing. | ||
|
|
||
| Downloading the file requires a GitHub account, so open this link on the | ||
| device you want to test on, or transfer the APK to it. | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be multi-line to make it work.