fix(upload): pause

[alperozturk96]

How to reproduce?

1. Try upload a big file to the root
2. Pause it
3. Create new folder
4. Try upload big file to the newly created folder

Expected

First upload should be paused, second upload should be uploaded

Actual

Both files are uploaded and notification disappears

Changes

• Fixes global pause action so that current uploads can be paused
• Fixes pause action

[github-actions]

📱 QA build

Download	app-qa-debug.apk (76M)
QR code	Open the QR code for this download
Commit	dae8386
Version	17632
Available until	7 days after this build

The QA build installs alongside a released Nextcloud app, so you can keep
using your existing install while testing.

Downloading the file requires a GitHub account, so open this link on the
device you want to test on, or transfer the APK to it.

[github-actions]

blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed.

[alperozturk96]

/backport to stable-35.0.x

[codecov]

Codecov Report

❌ Patch coverage is 10.81081% with 33 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
...m/nextcloud/client/jobs/upload/FileUploadWorker.kt	0.00%	9 Missing and 3 partials ⚠️
...tcloud/client/jobs/upload/AlbumFileUploadWorker.kt	0.00%	6 Missing ⚠️
...wncloud/android/datamodel/UploadsStorageManager.kt	16.66%	3 Missing and 2 partials ⚠️
...owncloud/android/ui/activity/UploadListActivity.kt	0.00%	5 Missing ⚠️
...ncloud/android/operations/UploadFileOperation.java	50.00%	3 Missing ⚠️
...tils/extensions/RemoteOperationResultExtensions.kt	0.00%	0 Missing and 1 partial ⚠️
...ain/java/com/owncloud/android/db/UploadResult.java	0.00%	1 Missing ⚠️

📢 Thoughts on this report? Let us know!

[daniele-verducci]

Hey Alper, I tested it but the paused upload is listed as "cancelled":

To be sure I'm testing it the right way, here what I've done:

• upload big file
• pause upload from notification
• create folder
• upload same big file in folder
• go to menu -> uploads to check progression: first upload is shown as cancelled, second one is uploading correctly

Here I should wee the first one as paused and the second one running if I interpreted the first post right.

If I do the same test, but pausing from the Uploads list instead of the notification:

• upload big file
• pause upload from the Uploads list
• create folder
• upload same big file in folder
• in Uploads list both are paused
• if I un-pause from there, the first resumes upload and, after finished, the second one starts

This last behavior seems correct to me.

[alperozturk96]

Hey Alper, I tested it but the paused upload is listed as "cancelled":

To be sure I'm testing it the right way, here what I've done:

• upload big file
• pause upload from notification
• create folder
• upload same big file in folder
• go to menu -> uploads to check progression: first upload is shown as cancelled, second one is uploading correctly

Here I should wee the first one as paused and the second one running if I interpreted the first post right.

If I do the same test, but pausing from the Uploads list instead of the notification:

• upload big file
• pause upload from the Uploads list
• create folder
• upload same big file in folder
• in Uploads list both are paused
• if I un-pause from there, the first resumes upload and, after finished, the second one starts

This last behavior seems correct to me.

Both behaves same for me. I didn't understand what is wrong? Upload listed as cancelled because user wanted to pause it.

Wording, UI/UX wise it's not good but this is out of scope for this PR. Could you please share your screen recording that shows bug?

Demo

Screen_recording_20260915_132702.mp4

[daniele-verducci]

Thanks for the video. There was a little of a misunderstanding here: I tought that the "pause" button in the notification was functionally equal to the main pause button in the upload window (the top-right one):

While I considered the "X" button a "cancel" button.

So, considering this, now it make sense and functionally is ok (= it works as intended), but I think it's still misleading (but as you said, out of scope for this PR)

[github-actions]

Codacy

SpotBugs

Category	Base	New
Bad practice	32	32
Correctness	58	58
Dodgy code	186	186
Experimental	1	1
Malicious code vulnerability	2	2
Multithreaded correctness	26	26
Performance	37	37
Security	19	19
Total	361	361