Skip to content

perf(file-list): avatar loading - #17667

Merged
alperozturk96 merged 4 commits into
masterfrom
fix/avatar-loading
Sep 22, 2026
Merged

alperozturk96 merged 4 commits into
masterfrom
fix/avatar-loading

Conversation

@alperozturk96

@alperozturk96 alperozturk96 commented Sep 17, 2026 •

Copy link
Copy Markdown
Collaborator

Issue

Scrolling up and down causing to re-generate avatars

Changes

  • Doing all job in background thread and render only in main thread
  • Adds unified share calls to the missing places

@alperozturk96 alperozturk96 added 3. to review performance 🚀 Performance improvement opportunities (non-crash related) labels Sep 17, 2026
@alperozturk96 alperozturk96 added this to the Nextcloud App 35.0.1 milestone Sep 17, 2026
@alperozturk96

Copy link
Copy Markdown
Collaborator Author

/backport to stable-35.0.x

@github-actions

Copy link
Copy Markdown

@github-actions

Copy link
Copy Markdown

Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@github-actions

Copy link
Copy Markdown

Codacy

SpotBugs

CategoryBaseNew
Bad practice3232
Correctness5858
Dodgy code186186
Experimental11
Malicious code vulnerability22
Multithreaded correctness2626
Performance3737
Security1818
Total360360

@github-actions

Copy link
Copy Markdown

📱 QA build

Download app-qa-debug.apk
QR code Open the QR code for this download
Commit 05afc6c
Version 17667
Available until 7 days after this build

The QA build installs alongside a released Nextcloud app, so you can keep
using your existing install while testing.

Downloading the file requires a GitHub account, so open this link on the
device you want to test on, or transfer the APK to it.

@daniele-verducci daniele-verducci left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Alper, this seems good to me, so I approved.
Anyway, I found a bug that has NOT been introduced in this one (already present on master) that may be related, see video:

Screen_recording_20260922_113235.webm

Basically, at start the sharee icons are flickering and then only the first sharee is shown. When I move to Recent or Shared, then all the sharees are shown in the icon, and if I go back to files view, it remains like that until I reload the list.

@alperozturk96
alperozturk96 merged commit 49771e8 into master Sep 22, 2026
24 of 26 checks passed
@alperozturk96

Copy link
Copy Markdown
Collaborator Author

/backport to stable-35.0.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review performance 🚀 Performance improvement opportunities (non-crash related)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants