Skip to content

Implemented tests for encrypted folders - #17697

Merged
alperozturk96 merged 21 commits into
masterfrom
improvement/internal-105265-tests
Sep 29, 2026
Merged

alperozturk96 merged 21 commits into
masterfrom
improvement/internal-105265-tests

Conversation

@daniele-verducci

@daniele-verducci daniele-verducci commented Sep 23, 2026 •

Copy link
Copy Markdown
Contributor

Tests for encrypted (sub)folders.
Related: #17608

⚠️ The encrypted subfolders-related tests are supposed to fail in this one, until #17608 is merged
The folder unencryption test is failing as well, as the feature it's not working in the current master app!

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

🤖 AI (if applicable)

  • The content of this PR was partly or fully generated using AI (N/A)

@codecov

codecov Bot commented Sep 23, 2026 •

Copy link
Copy Markdown

@github-actions

github-actions Bot commented Sep 23, 2026 •

Copy link
Copy Markdown

📱 QA build

Download app-qa-debug.apk
QR code Open the QR code for this download
Commit 2d25b83
Version 17697
Available until 7 days after this build

The QA build installs alongside a released Nextcloud app, so you can keep
using your existing install while testing.

Downloading the file requires a GitHub account, so open this link on the
device you want to test on, or transfer the APK to it.

@daniele-verducci
daniele-verducci force-pushed the improvement/internal-105265-tests branch 2 times, most recently from 04133f4 to ae74111 Compare September 24, 2026 12:46
@daniele-verducci
daniele-verducci marked this pull request as ready for review September 24, 2026 13:11
Comment thread app/src/main/java/com/owncloud/android/operations/e2e/E2EDeletionService.kt Outdated
@github-actions

Copy link
Copy Markdown

stable22-IT test failed, but no output was generated. Maybe a preliminary stage failed.

@daniele-verducci
daniele-verducci force-pushed the improvement/internal-105265-tests branch from d1eace8 to e557a0f Compare September 28, 2026 08:27
@alperozturk96 alperozturk96 added the ♻️ refactor Refactor code (not a bug fix, not a feature just refactoring) label Sep 28, 2026
@alperozturk96

Copy link
Copy Markdown
Collaborator

/backport to stable-35.0.x

@daniele-verducci
daniele-verducci marked this pull request as draft September 28, 2026 14:35
@daniele-verducci
daniele-verducci force-pushed the improvement/internal-105265-tests branch 2 times, most recently from 36d4edb to 57bd0a7 Compare September 28, 2026 15:25
@daniele-verducci
daniele-verducci marked this pull request as ready for review September 28, 2026 15:30
@daniele-verducci

Copy link
Copy Markdown
Contributor Author

@alperozturk96 so now only testReadEncryptedSubfolder should fail.
In first post I said testCreateEncryptedSubfolder should fail, but it's wrong: in fact, when creating an encrypted subfolder the app crashes because after successfully creating it, tries to open it . So it's right all the tests are good but testReadEncryptedSubfolder fails.

@daniele-verducci
daniele-verducci force-pushed the improvement/internal-105265-tests branch from 57bd0a7 to 4818345 Compare September 28, 2026 15:33
@github-actions

Copy link
Copy Markdown

@github-actions

Copy link
Copy Markdown

Signed-off-by: daniele-verducci <daniele.verducci@nextcloud.com>
Signed-off-by: daniele-verducci <daniele.verducci@nextcloud.com>
daniele-verducci and others added 19 commits September 29, 2026 08:06
…able

Signed-off-by: daniele-verducci <daniele.verducci@nextcloud.com>
Signed-off-by: daniele-verducci <daniele.verducci@nextcloud.com>
Signed-off-by: daniele-verducci <daniele.verducci@nextcloud.com>
Signed-off-by: daniele-verducci <daniele.verducci@nextcloud.com>
Signed-off-by: daniele-verducci <daniele.verducci@nextcloud.com>
Signed-off-by: daniele-verducci <daniele.verducci@nextcloud.com>
Signed-off-by: daniele-verducci <daniele.verducci@nextcloud.com>
Signed-off-by: daniele-verducci <daniele.verducci@nextcloud.com>
Signed-off-by: daniele-verducci <daniele.verducci@nextcloud.com>
Signed-off-by: daniele-verducci <daniele.verducci@nextcloud.com>
Signed-off-by: daniele-verducci <daniele.verducci@nextcloud.com>
Signed-off-by: daniele-verducci <daniele.verducci@nextcloud.com>
Signed-off-by: daniele-verducci <daniele.verducci@nextcloud.com>
Signed-off-by: daniele-verducci <daniele.verducci@nextcloud.com>
Signed-off-by: daniele-verducci <daniele.verducci@nextcloud.com>
Signed-off-by: daniele-verducci <daniele.verducci@nextcloud.com>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: daniele-verducci <daniele.verducci@nextcloud.com>
@alperozturk96
alperozturk96 force-pushed the improvement/internal-105265-tests branch from 4818345 to 2d25b83 Compare September 29, 2026 06:06
@github-actions

Copy link
Copy Markdown

Codacy

SpotBugs

CategoryBaseNew
Bad practice3232
Correctness5656
Dodgy code184184
Experimental11
Malicious code vulnerability22
Multithreaded correctness2626
Performance3535
Security1717
Total353353

@alperozturk96
alperozturk96 merged commit 3c70807 into master Sep 29, 2026
22 of 24 checks passed
@alperozturk96
alperozturk96 deleted the improvement/internal-105265-tests branch September 29, 2026 07:36
@github-actions

github-actions Bot commented Oct 8, 2026

Copy link
Copy Markdown

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review feedback-requested ♻️ refactor Refactor code (not a bug fix, not a feature just refactoring)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants