Skip to content

fix(media): scroll & pinch - #17703

Merged
alperozturk96 merged 5 commits into
masterfrom
fix/media-scroll-and-gestures
Oct 1, 2026
Merged

fix(media): scroll & pinch#17703
alperozturk96 merged 5 commits into
masterfrom
fix/media-scroll-and-gestures

Conversation

@alperozturk96

@alperozturk96 alperozturk96 commented Sep 24, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Changes

  • Via pinch user can change column size
  • Scroll is less laggy
  • Accesses cache without lock since gallery job used for it

@alperozturk96

alperozturk96 commented Sep 24, 2026

Copy link
Copy Markdown
Collaborator Author

/backport to stable-35.0.x

@github-actions

github-actions Bot commented Sep 24, 2026 •
edited
Loading

Copy link
Copy Markdown

📱 QA build
Download app-qa-debug.apk
QR code Open the QR code for this download
Commit a9cbb04
Version 17703
Available until 7 days after this build

The QA build installs alongside a released Nextcloud app, so you can keep
using your existing install while testing.

Downloading the file requires a GitHub account, so open this link on the
device you want to test on, or transfer the APK to it.

@codecov

codecov Bot commented Sep 24, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 58 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...om/owncloud/android/ui/fragment/GalleryFragment.kt 0.00% 38 Missing ⚠️
...android/ui/fragment/helper/GalleryPinchListener.kt 0.00% 12 Missing ⚠️
...loud/android/datamodel/ThumbnailsCacheManager.java 0.00% 4 Missing ⚠️
...d/client/jobs/gallery/GalleryImageGenerationJob.kt 0.00% 2 Missing ⚠️
...owncloud/android/ui/fragment/helper/ColumnCount.kt 0.00% 2 Missing ⚠️

📢 Thoughts on this report? Let us know!

@alperozturk96 alperozturk96 added this to the Nextcloud App 35.0.1 milestone Sep 24, 2026
@alperozturk96

alperozturk96 commented Sep 24, 2026

Copy link
Copy Markdown
Collaborator Author

/backport to stable-35.0.x

daniele-verducci

This comment was marked as resolved.

Sign in to view

@alperozturk96
add pinch listener for column change
e15a3ba 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
remove cache check since job already doing it
79eca43 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
speed-up load from disk
ae75d3b 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
use cached image without lock
dc8c428 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
alperozturk96 force-pushed the fix/media-scroll-and-gestures branch from 9525c75 to dc8c428 Compare September 30, 2026 08:00
@alperozturk96
fix interrupting with pinch and refresh
a9cbb04 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@github-actions

github-actions Bot commented Sep 30, 2026

Copy link
Copy Markdown

Codacy

SpotBugs

CategoryBaseNew
Bad practice3131
Correctness5656
Dodgy code182182
Experimental11
Malicious code vulnerability22
Multithreaded correctness2626
Performance3535
Security1717
Total350350

daniele-verducci
daniele-verducci approved these changes Oct 1, 2026
View reviewed changes

@daniele-verducci daniele-verducci left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice

@alperozturk96
alperozturk96 merged commit 55e5192 into master Oct 1, 2026
23 of 24 checks passed
@alperozturk96
alperozturk96 deleted the fix/media-scroll-and-gestures branch October 1, 2026 10:55
@backportbot backportbot Bot mentioned this pull request Oct 1, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@daniele-verducci daniele-verducci daniele-verducci approved these changes

Assignees

No one assigned

Labels

3. to review

Projects

None yet

Milestone

Nextcloud App 35.0.2

Development

Successfully merging this pull request may close these issues.

2 participants

@alperozturk96 @daniele-verducci