Skip to content

Seamless animation on navigation in media tab - #17705

Merged
alperozturk96 merged 8 commits into
masterfrom
fix/media-navigation
Sep 30, 2026
Merged

Seamless animation on navigation in media tab#17705
alperozturk96 merged 8 commits into
masterfrom
fix/media-navigation

Conversation

@alperozturk96

@alperozturk96 alperozturk96 commented Sep 24, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Changes

  • Fixes navigation when opening an image from Media, viewing its details, and pressing Back, it now returns to the image instead of the Media screen.
  • Fixes the image details animation, it now opens from the bottom instead of sliding in from the right.
  • Adds an animation when opening an image from Media.

@alperozturk96

alperozturk96 commented Sep 24, 2026

Copy link
Copy Markdown
Collaborator Author

/backport to stable-35.0.x

@alperozturk96 alperozturk96 added this to the Nextcloud App 35.0.1 milestone Sep 24, 2026
@github-actions

github-actions Bot commented Sep 24, 2026 •
edited
Loading

Copy link
Copy Markdown

📱 QA build
Download app-qa-debug.apk
QR code Open the QR code for this download
Commit 250abf6
Version 17705
Available until 7 days after this build

The QA build installs alongside a released Nextcloud app, so you can keep
using your existing install while testing.

Downloading the file requires a GitHub account, so open this link on the
device you want to test on, or transfer the APK to it.

@codecov

codecov Bot commented Sep 24, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 148 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...droid/ui/navigation/animator/NavigationAnimator.kt 0.00% 51 Missing ⚠️
.../ui/navigation/animator/SharedElementTransition.kt 0.00% 35 Missing ⚠️
...wncloud/android/ui/activity/FileDisplayActivity.kt 0.00% 30 Missing and 2 partials ⚠️
...wncloud/android/ui/preview/PreviewImageActivity.kt 0.00% 22 Missing ⚠️
...ncloud/android/ui/fragment/OCFileListFragment.java 0.00% 4 Missing ⚠️
.../owncloud/android/ui/adapter/OCFileListDelegate.kt 0.00% 2 Missing ⚠️
...oid/ui/interfaces/OCFileListFragmentInterface.java 0.00% 2 Missing ⚠️

📢 Thoughts on this report? Let us know!

jancborchardt
jancborchardt previously requested changes Sep 29, 2026
View reviewed changes

@jancborchardt jancborchardt left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes navigation when opening an image from Media, viewing its details, and pressing Back, it now returns to the image instead of the Media screen.

Nice, this works. But the navigation should be symmetric, the other way around from when opening details. Right now it’s only a crossfade.

Fixes the image details animation, it now opens from the bottom instead of sliding in from the right.

It’s better, but still not perfect: There is a second/duplicate image element created which moves up from all the way on the bottom. But the image is already there on the screen, in the center. :)

Adds an animation when opening an image from Media.

Same here, the animation seems to use a duplicate element and it could look a bit smoother. And the animation on back is just a slide to left, but it should instead use the inverse of the opening animation.

Also FYI @nimishavijay for details. :)

@jancborchardt jancborchardt moved this to 🏗️ At engineering in 🖍 Design team Sep 29, 2026
@jancborchardt jancborchardt added papercut Annoying recurring issue with possibly simple fix design labels Sep 29, 2026
daniele-verducci
daniele-verducci previously requested changes Sep 29, 2026
View reviewed changes

@daniele-verducci daniele-verducci left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Alper, when editing a picture without making any change, the image is saved again (if I understood from the PR description it shouldn't happen, if that's the meaning of Fixes the edit flow, users can no longer view an edited image when they tap Edit without making any changes).
Also, it appears cropped in the adapter, not sure why (the image is identical to the original)

Screen_recording_20260929_182626.webm

@alperozturk96
fix(media): navigation
116decb 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>

# Conflicts:
#	app/src/main/java/com/nextcloud/utils/extensions/ViewExtensions.kt
@alperozturk96
wip
b5359e2 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
create navigation animator
576af49 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
use m3 slide down and up
0426439 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
use scale up and down for opening and close image
a039a14 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
slide up image from center
560bca9 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96

alperozturk96 commented Sep 30, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator Author

Hey Alper, when editing a picture without making any change, the image is saved again (if I understood from the PR description it shouldn't happen, if that's the meaning of Fixes the edit flow, users can no longer view an edited image when they tap Edit without making any changes). Also, it appears cropped in the adapter, not sure why (the image is identical to the original)

Screen_recording_20260929_182626.webm

I cant able to reproduce it. We can check this in different PR.

Screen_recording_20260930_094806.mp4

@alperozturk96

alperozturk96 commented Sep 30, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator Author

Fixes navigation when opening an image from Media, viewing its details, and pressing Back, it now returns to the image instead of the Media screen.

Nice, this works. But the navigation should be symmetric, the other way around from when opening details. Right now it’s only a crossfade.

Fixes the image details animation, it now opens from the bottom instead of sliding in from the right.

It’s better, but still not perfect: There is a second/duplicate image element created which moves up from all the way on the bottom. But the image is already there on the screen, in the center. :)

Adds an animation when opening an image from Media.

Same here, the animation seems to use a duplicate element and it could look a bit smoother. And the animation on back is just a slide to left, but it should instead use the inverse of the opening animation.

Also FYI @nimishavijay for details. :)

Tried to fix all. Slide up and slide down especially a bit tricky without using bottom-sheet for the file details screen and this requires more effort.

What do you think?

Screen_recording_20260930_0957222222.mp4

@jancborchardt

jancborchardt commented Sep 30, 2026

Copy link
Copy Markdown
Member

That's nicer, it's a bit glitchy in the beginning though as on image opening the status bar gets removed and the "Media" header shifts up?

@alperozturk96
fix transitions
78a4525 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96

alperozturk96 commented Sep 30, 2026

Copy link
Copy Markdown
Collaborator Author

That's nicer, it's a bit glitchy in the beginning though as on image opening the status bar gets removed and the "Media" header shifts up?

Updated:

TAscreen-20260930-105359.mp4

jancborchardt
jancborchardt approved these changes Sep 30, 2026
View reviewed changes

@jancborchardt jancborchardt left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MUCH much better, looks very nice and seamless now! :)

@alperozturk96
fix kotlin spotless check
250abf6 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@github-actions

github-actions Bot commented Sep 30, 2026

Copy link
Copy Markdown

Codacy

SpotBugs

CategoryBaseNew
Bad practice3131
Correctness5656
Dodgy code182182
Experimental11
Malicious code vulnerability22
Multithreaded correctness2626
Performance3535
Security1717
Total350350

@github-actions

github-actions Bot commented Sep 30, 2026

Copy link
Copy Markdown

stable35-IT test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/17705-IT-stable35-11-08

@jancborchardt jancborchardt changed the title fix(media): navigation Seamless animation on navigation in media tab Sep 30, 2026
@alperozturk96
alperozturk96 merged commit 7f464c5 into master Sep 30, 2026
21 of 24 checks passed
@alperozturk96
alperozturk96 deleted the fix/media-navigation branch September 30, 2026 13:00
@backportbot backportbot Bot mentioned this pull request Sep 30, 2026
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jancborchardt jancborchardt jancborchardt approved these changes
@nimishavijay nimishavijay Awaiting requested review from nimishavijay
@daniele-verducci daniele-verducci Awaiting requested review from daniele-verducci

Assignees

No one assigned

Labels

3. to review design papercut Annoying recurring issue with possibly simple fix

Projects

🖍 Design team
Status: 🎉 Done

Milestone

Nextcloud App 35.0.2

Development

Successfully merging this pull request may close these issues.

3 participants

@alperozturk96 @jancborchardt @daniele-verducci