Skip to content

refactor(player): remove unused execution flow - #17724

Merged
alperozturk96 merged 6 commits into
masterfrom
refactor/player
Sep 28, 2026
Merged

alperozturk96 merged 6 commits into
masterfrom
refactor/player

Conversation

@alperozturk96

@alperozturk96 alperozturk96 commented Sep 28, 2026 •

Copy link
Copy Markdown
Collaborator

Changes

  • PlayerActivity only used for audio playback and PreviewPlaybackFragment responsible for previewing media item. This was causing confusion and it cleaned up via this PR.
  • Additionally, contains small UI fixes such as 3 nav-bar color not matches with device mode and colliding with player controls.

Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96

Copy link
Copy Markdown
Collaborator Author

/backport to stable-35.0.x

@github-actions

github-actions Bot commented Sep 28, 2026 •

Copy link
Copy Markdown

📱 QA build

Download app-qa-debug.apk
QR code Open the QR code for this download
Commit 05b5f26
Version 17724
Available until 7 days after this build

The QA build installs alongside a released Nextcloud app, so you can keep
using your existing install while testing.

Downloading the file requires a GitHub account, so open this link on the
device you want to test on, or transfer the APK to it.

@github-actions

Copy link
Copy Markdown

daniele-verducci

This comment was marked as resolved.

Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@github-actions

Copy link
Copy Markdown

Codacy

SpotBugs

CategoryBaseNew
Bad practice3232
Correctness5656
Dodgy code184184
Experimental11
Malicious code vulnerability22
Multithreaded correctness2626
Performance3535
Security1717
Total353353

@daniele-verducci daniele-verducci left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect

@alperozturk96
alperozturk96 merged commit 007fe67 into master Sep 28, 2026
22 of 24 checks passed
@alperozturk96
alperozturk96 deleted the refactor/player branch September 28, 2026 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants