Skip to content

Check file name length doesn't exceed server's supported one - #17736

Merged
alperozturk96 merged 8 commits into
masterfrom
fix/internal-106518
Oct 2, 2026
Merged

alperozturk96 merged 8 commits into
masterfrom
fix/internal-106518

Conversation

@daniele-verducci

@daniele-verducci daniele-verducci commented Sep 29, 2026 •

Copy link
Copy Markdown
Contributor

Check file name length doesn't exceed server's supported one

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

🤖 AI (if applicable)

  • The content of this PR was partly or fully generated using AI (N/A)

@daniele-verducci daniele-verducci self-assigned this Sep 29, 2026
@daniele-verducci daniele-verducci added this to the Nextcloud App 35.0.1 milestone Sep 29, 2026
@github-actions

github-actions Bot commented Sep 29, 2026 •

Copy link
Copy Markdown

📱 QA build

Download app-qa-debug.apk
QR code Open the QR code for this download
Commit 48eca42
Version 17736
Available until 7 days after this build

The QA build installs alongside a released Nextcloud app, so you can keep
using your existing install while testing.

Downloading the file requires a GitHub account, so open this link on the
device you want to test on, or transfer the APK to it.

@codecov

codecov Bot commented Sep 29, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 3.92157% with 49 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
.../android/ui/dialog/ChooseTemplateDialogFragment.kt 0.00% 49 Missing ⚠️

📢 Thoughts on this report? Let us know!

daniele-verducci and others added 7 commits October 1, 2026 15:08
Signed-off-by: daniele-verducci <daniele.verducci@nextcloud.com>

# Conflicts:
#	app/src/main/java/com/owncloud/android/ui/dialog/ChooseTemplateDialogFragment.kt
Signed-off-by: daniele-verducci <daniele.verducci@nextcloud.com>
Signed-off-by: daniele-verducci <daniele.verducci@nextcloud.com>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@github-actions

github-actions Bot commented Oct 1, 2026

Copy link
Copy Markdown

Codacy

SpotBugs

CategoryBaseNew
Bad practice3130
Correctness5555
Dodgy code181178
Experimental11
Malicious code vulnerability22
Multithreaded correctness2626
Performance3535
Security1616
Total347343

@daniele-verducci

Copy link
Copy Markdown
Contributor Author

@alperozturk96 I re-tested it after the changes, it's all ok, you can merge! Thx!

@alperozturk96
alperozturk96 merged commit 2e5614f into master Oct 2, 2026
22 of 23 checks passed
@alperozturk96
alperozturk96 deleted the fix/internal-106518 branch October 2, 2026 06:47
@github-actions

Copy link
Copy Markdown

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants