Skip to content

fix(account): switching - #17739

Merged
alperozturk96 merged 5 commits into
masterfrom
fix/color-switching
Oct 5, 2026
Merged

alperozturk96 merged 5 commits into
masterfrom
fix/color-switching

Conversation

@alperozturk96

Copy link
Copy Markdown
Collaborator

Steps to reproduce

  1. Create an two account with different color set and file listing
  2. Switch between them multiple times
  3. Colors are not changes e.g. folder colors

Demo

fixscreen-20260930-111452.mp4

private val themeCache: MutableMap<String, MaterialSchemes> = ConcurrentHashMap()

override fun getMaterialSchemesForUser(user: User): MaterialSchemes {
val url: String = user.server.uri.toString()

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

user.server.uri.toString() -> only gives us something like http://localhost:8080

@jancborchardt jancborchardt left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing!

@codecov

codecov Bot commented Sep 30, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 77.77778% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...extcloud/utils/thumbnail/FileThumbnailGenerator.kt 66.66% 0 Missing and 1 partial ⚠️
...android/utils/theme/MaterialSchemesProviderImpl.kt 75.00% 0 Missing and 1 partial ⚠️

📢 Thoughts on this report? Let us know!

@github-actions

github-actions Bot commented Sep 30, 2026 •

Copy link
Copy Markdown

📱 QA build

Download app-qa-debug.apk
QR code Open the QR code for this download
Commit f9f16f7
Version 17739
Available until 7 days after this build

The QA build installs alongside a released Nextcloud app, so you can keep
using your existing install while testing.

Downloading the file requires a GitHub account, so open this link on the
device you want to test on, or transfer the APK to it.

@jancborchardt jancborchardt added the papercut Annoying recurring issue with possibly simple fix label Sep 30, 2026
@jancborchardt jancborchardt moved this to 🏗️ At engineering in 🖍 Design team Sep 30, 2026
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
… Provider can gives us retrieving multiple instances.

Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
  already provides same

Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@github-actions

github-actions Bot commented Oct 1, 2026

Copy link
Copy Markdown

master-IT test failed, but no output was generated. Maybe a preliminary stage failed.

@github-actions

github-actions Bot commented Oct 1, 2026

Copy link
Copy Markdown

Codacy

SpotBugs

CategoryBaseNew
Bad practice3130
Correctness5555
Dodgy code181178
Experimental11
Malicious code vulnerability22
Multithreaded correctness2626
Performance3535
Security1616
Total347343

@alperozturk96
alperozturk96 merged commit 1c9a4ce into master Oct 5, 2026
30 of 34 checks passed
@alperozturk96
alperozturk96 deleted the fix/color-switching branch October 5, 2026 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review papercut Annoying recurring issue with possibly simple fix

Projects

Status: 🎉 Done

Development

Successfully merging this pull request may close these issues.

Stability: test account switching

3 participants