Repository navigation
fix(unified-share): use credentials.username - #17742
Merged
Merged
Conversation
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
4 tasks done
4 tasks done
Collaborator
Author
|
/backport to stable-35.0.x |
📱 QA build
The QA build installs alongside a released Nextcloud app, so you can keep Downloading the file requires a GitHub account, so open this link on the |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
Tested the QA build against our affected setup (LDAP, UUID as internal UID): fixes the issue, log stays completely clean. Details in #17707. Thanks! |
|
stable35-IT test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/17742-IT-stable35-13-13 |
Collaborator
Author
|
/backport to stable-35.0.1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
credentials.usernamegives account name for all cases including ldap.