Skip to content

perf(file-detail-fragment): replace event bus with worker observation - #17785

Merged
alperozturk96 merged 8 commits into
masterfrom
perf/replace-file-download-progress-event-bus
Oct 12, 2026
Merged

alperozturk96 merged 8 commits into
masterfrom
perf/replace-file-download-progress-event-bus

Conversation

@alperozturk96

@alperozturk96 alperozturk96 commented Oct 8, 2026 •

Copy link
Copy Markdown
Collaborator

Implements: #17765

How to test?

  1. Open file detail
  2. From 3-dot menu tap download
  3. Observe progress indicator in the same detail screen

🤖 AI (if applicable)

  • The content of this PR was partly or fully generated using AI (N/A)

@alperozturk96 alperozturk96 added 3. to review performance 🚀 Performance improvement opportunities (non-crash related) labels Oct 8, 2026
@alperozturk96 alperozturk96 linked an issue Oct 8, 2026 that may be closed by this pull request
@alperozturk96 alperozturk96 added this to the Nextcloud App 35.1.0 milestone Oct 8, 2026
@github-actions

github-actions Bot commented Oct 8, 2026

Copy link
Copy Markdown

📱 QA build

Download app-qa-debug.apk
QR code Open the QR code for this download
Commit 0202a32
Version 17785
Available until 7 days after this build

The QA build installs alongside a released Nextcloud app, so you can keep
using your existing install while testing.

Downloading the file requires a GitHub account, so open this link on the
device you want to test on, or transfer the APK to it.

@codecov

codecov Bot commented Oct 8, 2026

Copy link
Copy Markdown

@alperozturk96 alperozturk96 changed the title perf(file-detail-fragment): replace event bus with proper worker observation perf(file-detail-fragment): replace event bus with worker observation Oct 8, 2026
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>

# Conflicts:
#	app/src/main/java/com/owncloud/android/ui/fragment/FileDetailFragment.java
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
alperozturk96 force-pushed the perf/replace-file-download-progress-event-bus branch from 0202a32 to a614acf Compare October 12, 2026 11:08
@github-actions

Copy link
Copy Markdown

Codacy

SpotBugs

CategoryBaseNew
Bad practice2525
Correctness5252
Dodgy code175175
Experimental11
Malicious code vulnerability22
Multithreaded correctness2626
Performance3030
Security1616
Total327327

@alperozturk96
alperozturk96 merged commit 404ddc5 into master Oct 12, 2026
22 of 24 checks passed
@alperozturk96
alperozturk96 deleted the perf/replace-file-download-progress-event-bus branch October 12, 2026 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review performance 🚀 Performance improvement opportunities (non-crash related)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove EventBus

2 participants