Repository navigation
perf(bitmap): recycle - #17786
Merged
Merged
perf(bitmap): recycle#17786
Conversation
📱 QA build
The QA build installs alongside a released Nextcloud app, so you can keep Downloading the file requires a GitHub account, so open this link on the |
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
daniele-verducci
approved these changes
Oct 12, 2026
alperozturk96
force-pushed
the
perf/bitmap-usage
branch
from
October 12, 2026 10:43
15e6d85 to
775c2cd
Compare
Signed-off-by: alperozturk96 <alper_ozturk@proton.me> # Conflicts: # app/src/main/java/com/owncloud/android/datamodel/ThumbnailsCacheManager.java
alperozturk96
force-pushed
the
perf/bitmap-usage
branch
from
October 12, 2026 10:47
775c2cd to
44fa662
Compare
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements: #17640
Changes
ComponentCallbacks2forFileThumbnailGenerator.ktso that we can do cleanup job.ThumbnailUtils.OPTIONS_RECYCLE_INPUTso that we can recycle the input inextractThumbnail(Bitmap,int,int,int)Bitmaprelated logics toBitmapUtils.ktinstead having them inThumbnailCacheManager.javaHow to test?